Bug 1229727

Summary:	Unable to find VM with Id: [122] [catalog/tree_select]
Product:	Red Hat CloudForms Management Engine	Reporter:	Milan Falešník <mfalesni>
Component:	Insight	Assignee:	Oleg Barenboim <obarenbo>
Status:	CLOSED DUPLICATE	QA Contact:	Dave Johnson <dajohnso>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	5.4.0	CC:	dclarizi, gblomqui, gmccullo
Target Milestone:	GA
Target Release:	5.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-10 16:12:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Milan Falešník 2015-06-09 14:05:35 UTC

Description of problem:
When you delete a template that is used for certain catalog item, then it will explode every time you want to view the details.

Version-Release number of selected component (if applicable):
5.4.0.5

How reproducible:
always

Steps to Reproduce:
1. Create a catalog item that uses some template
2. Delete that template from VMDB
3. Access the Catalog Item

Actual results:
Unable to find VM with Id: [122] [catalog/tree_select]

Expected results:
I would expect some flash message saying that the item is unusable because it does not have the template OR the template won't be possible to delete.

Additional info:

Comment 3 Greg McCullough 2015-06-10 14:26:17 UTC

We have a PR (https://github.com/ManageIQ/manageiq/pull/2947 - not merged yet) that is trying to deal with the issue at the model layer.  If a template is no longer available for provisioning (orphaned, archived or deleted) it will allow the user to re-enter the catalog item to select a new template.

The validation of the workflow template was moved into a separate method to allow it to be called, likely by the UI, to display errors/warnings.

I would expect a few things to happen in the UI if a catalog item was determined to be in error:
1) The catalog item is marked in the UI
2) Any catalog bundle containing a bad catalog item would be marked in the UI
3) Catalog items/bundles would be hidden from the service ordering screen.

Comment 4 Greg McCullough 2015-06-10 14:30:39 UTC

Related bugs: Bug 1210541 & Bug 1223911