Bug 1230497

Summary: BuildRequires on gcc-c++ not glibc-headers, and remove Requires on glibc-headers.
Product: [Fedora] Fedora Reporter: Carlos O'Donell <codonell>
Component: shedskinAssignee: Thomas Spura <tomspur>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: tomspur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-06-11 14:49:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1230505    

Description Carlos O'Donell 2015-06-11 04:17:56 UTC
Two issues:

Please replace the BuildRequires: glibc-headers with BuildRequires: gcc-c++. The new Fedora packaging guidelines require you define all the things you need in the buildroot to build [1].

Given that this package has C++ code it should BuildRequires: gcc-c++, and that is sufficient to bring in all of the required core C/C++ libraries and headers to compile C/C++ code.

The reason I'm asking is because glibc-headers may or may not be removed in the future and it isn't sufficient to guarantee the package builds.

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2

Secondly, the Requires: glibc-headers should be removed, it is insufficient to allow Makefile's produced by shedskin to run, and if that is desired it should be replaced by Requires: gcc-g++ (to provide the compiler and headres and libraries to build the resulting translated C++).

Comment 1 Thomas Spura 2015-06-11 14:49:32 UTC
Building in rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=10018798