Bug 1230497 - BuildRequires on gcc-c++ not glibc-headers, and remove Requires on glibc-headers.
Summary: BuildRequires on gcc-c++ not glibc-headers, and remove Requires on glibc-head...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: shedskin
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Thomas Spura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1230505
TreeView+ depends on / blocked
 
Reported: 2015-06-11 04:17 UTC by Carlos O'Donell
Modified: 2015-06-11 14:49 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-06-11 14:49:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Carlos O'Donell 2015-06-11 04:17:56 UTC
Two issues:

Please replace the BuildRequires: glibc-headers with BuildRequires: gcc-c++. The new Fedora packaging guidelines require you define all the things you need in the buildroot to build [1].

Given that this package has C++ code it should BuildRequires: gcc-c++, and that is sufficient to bring in all of the required core C/C++ libraries and headers to compile C/C++ code.

The reason I'm asking is because glibc-headers may or may not be removed in the future and it isn't sufficient to guarantee the package builds.

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2

Secondly, the Requires: glibc-headers should be removed, it is insufficient to allow Makefile's produced by shedskin to run, and if that is desired it should be replaced by Requires: gcc-g++ (to provide the compiler and headres and libraries to build the resulting translated C++).

Comment 1 Thomas Spura 2015-06-11 14:49:32 UTC
Building in rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=10018798


Note You need to log in before you can comment on or make changes to this bug.