Bug 1231069

Summary: Duplicate data and graphs on Optimize->Utilization pages with time profiles that have C&U data roll up enabled
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: UI - OPSAssignee: Gregg Tanzillo <gtanzill>
Status: CLOSED ERRATA QA Contact: Nandini Chandra <nachandr>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.4.0CC: cpelland, hkataria, jhardy, mfeifer, mpovolny, nachandr, obarenbo
Target Milestone: GAKeywords: ZStream
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1252584 (view as bug list) Environment:
Last Closed: 2015-12-08 13:13:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1252584    
Attachments:
Description Flags
screenshot of optimize summary tab
none
screenshot of Optimize report tab none

Description Nandini Chandra 2015-06-12 06:32:38 UTC
Created attachment 1037917 [details]
screenshot of optimize summary tab

Description of problem:
-----------------------


Version-Release number of selected component (if applicable):
------------------------
5.4.0.5


How reproducible:
-----------------
Always


Steps to Reproduce:
------------------
1.Enable C&U collection
2.Create mutliple time profiles,enable C&U data roll up for the time profiles
3.Navigate to the Optimize->Utilization page for a host.


Actual results:
--------------
1)Observe that the Report tab has duplicate data.
The following data is duplicated in the CPU and Memory sections.
Total,Max used,Avg used

2)Summary tab has duplicate charts for memory and CPU Utilization
The 'Total' row is present twice in the CPU and Memory sections.


Expected results:
----------------
No duplicate data should be present in the Optimize->Utilization page.


Additional info:
---------------
Also,refer to https://bugzilla.redhat.com/show_bug.cgi?id=1230786 where I've reported a similar issue related to daily C&U graphs.

Comment 1 Nandini Chandra 2015-06-12 06:34:59 UTC
Created attachment 1037918 [details]
screenshot of Optimize report tab

Comment 4 Gregg Tanzillo 2015-07-29 16:37:25 UTC
This is most likely a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1230786

Comment 6 Nandini Chandra 2015-08-03 09:07:16 UTC
Resetting the NEEDINFO flag

Comment 7 CFME Bot 2015-08-03 18:56:27 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=3b1c6250f57bc3f1dce260480b0de70af28e635c

commit 3b1c6250f57bc3f1dce260480b0de70af28e635c
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Thu Jul 30 08:23:01 2015 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Thu Jul 30 15:59:30 2015 -0400

    Treat classes that have "derived" instances (instances_are_derived? => true) the same as classes that derive from ActsAsArModel and call custom find method. This was preventing the custom find method in VimPerformanceDaily from being called which caused time profiles to be ignored and return multiple rows for the same day when multiple time profiles exist.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1231069
    https://bugzilla.redhat.com/show_bug.cgi?id=1230786

 vmdb/app/models/rbac.rb                  | 2 +-
 vmdb/app/models/vim_performance_daily.rb | 2 ++
 vmdb/spec/models/rbac_spec.rb            | 7 +++++++
 3 files changed, 10 insertions(+), 1 deletion(-)

Comment 8 CFME Bot 2015-08-03 18:56:35 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=95a733b9bca72866af6e0d1ac1d3084384d8c46a

commit 95a733b9bca72866af6e0d1ac1d3084384d8c46a
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Fri Jul 31 16:50:04 2015 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Fri Jul 31 16:50:04 2015 -0400

    Added tests for daily performance find with time profile, limit and offset.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1231069
    https://bugzilla.redhat.com/show_bug.cgi?id=1230786

 vmdb/spec/models/vim_performance_daily_spec.rb | 77 ++++++++++++++++++++++++++
 1 file changed, 77 insertions(+)
 create mode 100644 vmdb/spec/models/vim_performance_daily_spec.rb

Comment 9 CFME Bot 2015-08-03 18:56:42 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=67e3cbd9074acd96b9982e82f1908b769058d0ef

commit 67e3cbd9074acd96b9982e82f1908b769058d0ef
Merge: fa41d2f 9a94873
Author:     Dan Clarizio <dclarizi>
AuthorDate: Mon Aug 3 14:55:15 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Mon Aug 3 14:55:15 2015 -0400

    Merge branch 'fix-timelines-in-daily-cu' into '5.4.z'
    
    Fixes issue where timelines are ignored and multiple days from daily performance are displayed in C&U detailed reports.
    
    Treat classes that have "derived" instances (instances_are_derived? => true) theā€¦ same as classes that derive from ActsAsArModel and call custom find method. This was preventing the custom find method in VimPerformanceDaily from being called which caused time profiles to be ignored and return multiple rows for the same day when multiple time profiles exist.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1231069
    https://bugzilla.redhat.com/show_bug.cgi?id=1230786
    
    See merge request !205

 vmdb/app/models/rbac.rb                        |  2 +-
 vmdb/app/models/vim_performance_daily.rb       |  2 +
 vmdb/spec/models/rbac_spec.rb                  |  7 +++
 vmdb/spec/models/vim_performance_daily_spec.rb | 79 ++++++++++++++++++++++++++
 4 files changed, 89 insertions(+), 1 deletion(-)

Comment 10 CFME Bot 2015-08-03 18:56:50 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9a9487320d7f01103d3b8ab8ce924e890aece311

commit 9a9487320d7f01103d3b8ab8ce924e890aece311
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Fri Jul 31 17:05:06 2015 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Fri Jul 31 17:05:06 2015 -0400

    Added explicit ordering in the test to ensure the expected result is in the correct sequece.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1231069
    https://bugzilla.redhat.com/show_bug.cgi?id=1230786

 vmdb/spec/models/vim_performance_daily_spec.rb | 2 ++
 1 file changed, 2 insertions(+)

Comment 11 CFME Bot 2015-08-03 18:56:57 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=70766d7650a7de235fd0dea88765098a07ef2f54

commit 70766d7650a7de235fd0dea88765098a07ef2f54
Author:     Gregg Tanzillo <gtanzill>
AuthorDate: Thu Jul 30 16:36:51 2015 -0400
Commit:     Gregg Tanzillo <gtanzill>
CommitDate: Thu Jul 30 16:38:15 2015 -0400

    Fixed incorrect call to limit on offset line.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1231069
    https://bugzilla.redhat.com/show_bug.cgi?id=1230786

 vmdb/app/models/vim_performance_daily.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 13 Nandini Chandra 2015-10-13 21:05:35 UTC
Verified in 5.5.0.5

Comment 15 errata-xmlrpc 2015-12-08 13:13:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551