Bug 1231354
| Summary: | Review Request: php-oojs-oojs-ui - Object-Oriented JavaScript – User Interface | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Cronenworth <mike> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review, shawn | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-oojs-oojs-ui-0.11.6-1.fc22 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-07-04 20:13:17 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1230630 | ||||||||
| Attachments: |
|
||||||||
|
Description
Michael Cronenworth
2015-06-12 19:18:16 UTC
* Shouldn't source come from https://github.com/wikimedia/oojs-ui as that's where Composer installs from? -- https://packagist.org/packages/oojs/oojs-ui * Per https://fedoraproject.org/wiki/Packaging:PHP#Naming_scheme, name should be "php-oojs-oojs-ui" * Per https://fedoraproject.org/wiki/Packaging:PHP#File_Placement, install path should be "/usr/share/php/OOUI/*" to be PSR-0 compliant * Per https://fedoraproject.org/wiki/Packaging:PHP#Composer_registered_Packages, need to provide "php-composer(oojs/oojs-ui) = %{version}" * Tests are provided so they should be run in %check http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui.spec http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui-0.11.4-2.fc21.src.rpm Upstream is Wikimedia's git. Why is it preferred to use the github mirror? The provided test can only be loaded through composer. > The provided test can only be loaded through composer.
This is never true. composer is just a way to get an autoloader.
Trivial solution:
phpab --output php/autoload.php php
phpunit --bootstrap php/autoload.php
Missing composr.json as %doc
From phpcompatinfo report:
Requires: php-json, php-pcre
Requires, autoloader, tests and composer.json added. http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui.spec http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui-0.11.4-3.fc22.src.rpm Updated to the 0.11.6 release. http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui.spec http://michael.cronenworth.com/RPMS/php-oojs-oojs-ui-0.11.6-1.fc22.src.rpm Created attachment 1042976 [details]
phpci.log
phpCompatInfo version 4.3.0 DB built Jun 21 2015 20:17:04 CEST static analyze results
Created attachment 1042977 [details]
review.txt
Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
[~]: Requires correct, justified where necessary. missing php-spl (introduced by the autoloader) Please add it after import (not a blocker, spl is always there, cannot be build shared, but still required by Guidelines) === APPROVED === I will add spl. Thanks for the review. New Package SCM Request ======================= Package Name: php-oojs-oojs-ui Short Description: Object-Oriented JavaScript – User Interface Upstream URL: http://www.mediawiki.org/wiki/OOjs_UI Owners: mooninite Branches: f21 f22 InitialCC: Git done (by process-git-requests). php-oojs-oojs-ui-0.11.6-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-oojs-oojs-ui-0.11.6-1.fc22 php-oojs-oojs-ui-0.11.6-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-oojs-oojs-ui-0.11.6-1.fc21 php-oojs-oojs-ui-0.11.6-1.fc22 has been pushed to the Fedora 22 testing repository. php-oojs-oojs-ui-0.11.6-1.fc21 has been pushed to the Fedora 21 stable repository. php-oojs-oojs-ui-0.11.6-1.fc22 has been pushed to the Fedora 22 stable repository. |