Bug 1231782
| Summary: | rdma : porting log messages to a new framework | ||
|---|---|---|---|
| Product: | [Red Hat Storage] Red Hat Gluster Storage | Reporter: | Manikandan <mselvaga> |
| Component: | rdma | Assignee: | Manikandan <mselvaga> |
| Status: | CLOSED ERRATA | QA Contact: | SATHEESARAN <sasundar> |
| Severity: | medium | Docs Contact: | |
| Priority: | high | ||
| Version: | rhgs-3.1 | CC: | aavati, annair, nlevinki, nsathyan, rcyriac, rgowdapp, rtalur, rwheeler, smohan, vagarwal |
| Target Milestone: | --- | ||
| Target Release: | RHGS 3.1.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.1-7.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-29 05:03:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1202842 | ||
|
Description
Manikandan
2015-06-15 11:59:24 UTC
Patch merged upstream msater at http://review.gluster.org/#/c/9868/ Patch posted upstream 3.7 at http://review.gluster.org/#/c/10673/. Should check why it is not merged. The patch that fixes this in downstream: https://code.engineering.redhat.com/gerrit/#/c/51003/ Patch is merged in downstream. One more clean up patch is sent(dependent on this BZ). So moving status to POST. Master: http://review.gluster.org/#/c/11426/ (Merged) Release-3.7: http://review.gluster.org/#/c/11448/ Downstream: https://code.engineering.redhat.com/gerrit/#/c/51759/ The dependent patch is also merged in Release-3.7 and in Downstream. I see that there few instances of gf_log in rdma.c & name.c
$ grep -r "gf_log " *
src/name.c: gf_log (this->name, GF_LOG_DEBUG,
src/name.c: gf_log (this->name, GF_LOG_ERROR,
src/rdma.c: gf_log ("rdma", GF_LOG_WARNING,
src/rdma.c: gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG,
There are only 2 files available under rdma
Marking this bug as FailedQA
(In reply to SATHEESARAN from comment #12) > src/rdma.c: gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG, Ignore this line as its commented in the source code. (In reply to SATHEESARAN from comment #12) > I see that there few instances of gf_log in rdma.c & name.c > > $ grep -r "gf_log " * > src/name.c: gf_log (this->name, GF_LOG_DEBUG, > src/name.c: gf_log (this->name, GF_LOG_ERROR, > src/rdma.c: gf_log ("rdma", > GF_LOG_WARNING, > src/rdma.c: gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG, > > > There are only 2 files available under rdma > > Marking this bug as FailedQA Have sent a patch to upstream master addressing the missing gf_log* http://review.gluster.org/#/c/11607/ (In reply to SATHEESARAN from comment #12) > I see that there few instances of gf_log in rdma.c & name.c > > $ grep -r "gf_log " * > src/name.c: gf_log (this->name, GF_LOG_DEBUG, > src/name.c: gf_log (this->name, GF_LOG_ERROR, > src/rdma.c: gf_log ("rdma", > GF_LOG_WARNING, > src/rdma.c: gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG, > > > There are only 2 files available under rdma > > Marking this bug as FailedQA As decided this bug will be verified with the available changes and I have opened another bug - https://bugzilla.redhat.com/show_bug.cgi?id=1242022 - for rest of the log messages porting. Moving this bug back ON_QA for verification Marking this bug as VERIFIED, as most of the log messages are ported to new logging framework. There are instances of gf_log and gf_log_callingfn, for which I have raised BZ 1242022 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-1495.html |