Bug 1231782 - rdma : porting log messages to a new framework
Summary: rdma : porting log messages to a new framework
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Gluster Storage
Classification: Red Hat Storage
Component: rdma
Version: rhgs-3.1
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: ---
: RHGS 3.1.0
Assignee: Manikandan
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1202842
TreeView+ depends on / blocked
 
Reported: 2015-06-15 11:59 UTC by Manikandan
Modified: 2016-09-20 04:28 UTC (History)
10 users (show)

Fixed In Version: glusterfs-3.7.1-7.el6
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-07-29 05:03:57 UTC
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:1495 0 normal SHIPPED_LIVE Important: Red Hat Gluster Storage 3.1 update 2015-07-29 08:26:26 UTC

Description Manikandan 2015-06-15 11:59:24 UTC
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Raghavendra Talur 2015-06-18 11:33:40 UTC
Patch merged upstream msater at http://review.gluster.org/#/c/9868/
Patch posted upstream 3.7    at http://review.gluster.org/#/c/10673/.

Should check why it is not merged.

Comment 6 Manikandan 2015-06-26 13:15:18 UTC
The patch that fixes this in downstream:
https://code.engineering.redhat.com/gerrit/#/c/51003/

Comment 7 Manikandan 2015-06-26 13:15:59 UTC
Patch is merged in downstream.

Comment 8 Manikandan 2015-06-27 12:57:15 UTC
One more clean up patch is sent(dependent on this BZ). So moving status to POST.
Master: 
http://review.gluster.org/#/c/11426/ (Merged)
Release-3.7: 
http://review.gluster.org/#/c/11448/
Downstream:
https://code.engineering.redhat.com/gerrit/#/c/51759/

Comment 9 Manikandan 2015-06-29 08:48:26 UTC
The dependent patch is also merged in Release-3.7 and in Downstream.

Comment 12 SATHEESARAN 2015-07-09 17:48:59 UTC
I see that there few instances of gf_log in rdma.c & name.c

$ grep -r "gf_log " *
src/name.c:                        gf_log (this->name, GF_LOG_DEBUG,
src/name.c:                        gf_log (this->name, GF_LOG_ERROR,
src/rdma.c:                                        gf_log ("rdma", GF_LOG_WARNING,
src/rdma.c:  gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG,


There are only 2 files available under rdma

Marking this bug as FailedQA

Comment 13 SATHEESARAN 2015-07-10 02:40:42 UTC
(In reply to SATHEESARAN from comment #12)

> src/rdma.c:  gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG,
Ignore this line as its commented in the source code.

Comment 14 Manikandan 2015-07-10 05:48:34 UTC
(In reply to SATHEESARAN from comment #12)
> I see that there few instances of gf_log in rdma.c & name.c
> 
> $ grep -r "gf_log " *
> src/name.c:                        gf_log (this->name, GF_LOG_DEBUG,
> src/name.c:                        gf_log (this->name, GF_LOG_ERROR,
> src/rdma.c:                                        gf_log ("rdma",
> GF_LOG_WARNING,
> src/rdma.c:  gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG,
> 
> 
> There are only 2 files available under rdma
> 
> Marking this bug as FailedQA

Have sent a patch to upstream master addressing the missing gf_log*

http://review.gluster.org/#/c/11607/

Comment 15 SATHEESARAN 2015-07-10 16:57:05 UTC
(In reply to SATHEESARAN from comment #12)
> I see that there few instances of gf_log in rdma.c & name.c
> 
> $ grep -r "gf_log " *
> src/name.c:                        gf_log (this->name, GF_LOG_DEBUG,
> src/name.c:                        gf_log (this->name, GF_LOG_ERROR,
> src/rdma.c:                                        gf_log ("rdma",
> GF_LOG_WARNING,
> src/rdma.c:  gf_log (GF_RDMA_LOG_NAME, GF_LOG_DEBUG,
> 
> 
> There are only 2 files available under rdma
> 
> Marking this bug as FailedQA

As decided this bug will be verified with the available changes and I have opened another bug - https://bugzilla.redhat.com/show_bug.cgi?id=1242022 - for rest of the log messages porting.

Moving this bug back ON_QA for verification

Comment 16 SATHEESARAN 2015-07-10 16:59:01 UTC
Marking this bug as VERIFIED, as most of the log messages are ported to new logging framework.

There are instances of gf_log and gf_log_callingfn, for which I have raised BZ 1242022

Comment 17 errata-xmlrpc 2015-07-29 05:03:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1495.html


Note You need to log in before you can comment on or make changes to this bug.