Bug 1231863

Summary:	Review Request: bcm283x-firmware - Broadcom bcm283x firmware for the Raspberry Pi
Product:	[Fedora] Fedora	Reporter:	Peter Robinson <pbrobinson>
Component:	Package Review	Assignee:	Tom "spot" Callaway <tcallawa>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, pwhalen
Target Milestone:	---	Flags:	tcallawa: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	armhfp
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-18 17:20:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Peter Robinson 2015-06-15 13:58:38 UTC

SPEC: https://pbrobinson.fedorapeople.org/bcm283x-firmware.spec
SRPM: https://pbrobinson.fedorapeople.org/bcm283x-firmware-20150615-1.37600d5.fc22.src.rpm
description:

Firmware for the Broadcom bcm283x SoC as shipped in devices such as the
Raspberry Pi

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10060140

Comment 1 Tom "spot" Callaway 2015-06-18 14:09:43 UTC

Minor items:

* the license tag must be:

"License: Redistributable, no modification permitted"

You've got a comment tacked on to the end, change it to look like this:

# see LICENSE.broadcom
License: Redistributable, no modification permitted

* Add a period at the end of the %description text.

* Change the URL to the github link, that's way more accurate.

Everything else looks clean here. There is no compilation, just file copying, and the source is correct. Make those changes, show me the fixed spec, and I'll approve.

Comment 2 Peter Robinson 2015-06-18 15:08:02 UTC

Updated

SPEC: https://pbrobinson.fedorapeople.org/bcm283x-firmware.spec
SRPM: https://pbrobinson.fedorapeople.org/bcm283x-firmware-20150615-2.37600d5.fc22.src.rpm

Comment 3 Tom "spot" Callaway 2015-06-18 15:12:56 UTC

Look at that license tag again. Almost there. ;)

Comment 4 Peter Robinson 2015-06-18 15:18:58 UTC

Bah.

SRPM: https://pbrobinson.fedorapeople.org/bcm283x-firmware-20150615-3.37600d5.fc22.src.rpm

Spec url the same

Comment 5 Tom "spot" Callaway 2015-06-18 15:21:07 UTC

Nice work. APPROVED.

Comment 6 Peter Robinson 2015-06-18 15:40:35 UTC

spot: thanks a lot for the review

New Package GIT Request
=======================
Package Name: bcm283x-firmware
Short Description: Broadcom bcm283x firmware for the Raspberry Pi 
Owners: pbrobinson pwhalen
Branches: F-22
InitialCC:

Comment 7 Gwyn Ciesla 2015-06-18 16:46:43 UTC

Git done (by process-git-requests).