SPEC: https://pbrobinson.fedorapeople.org/bcm283x-firmware.spec SRPM: https://pbrobinson.fedorapeople.org/bcm283x-firmware-20150615-1.37600d5.fc22.src.rpm description: Firmware for the Broadcom bcm283x SoC as shipped in devices such as the Raspberry Pi koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10060140
Minor items: * the license tag must be: "License: Redistributable, no modification permitted" You've got a comment tacked on to the end, change it to look like this: # see LICENSE.broadcom License: Redistributable, no modification permitted * Add a period at the end of the %description text. * Change the URL to the github link, that's way more accurate. Everything else looks clean here. There is no compilation, just file copying, and the source is correct. Make those changes, show me the fixed spec, and I'll approve.
Updated SPEC: https://pbrobinson.fedorapeople.org/bcm283x-firmware.spec SRPM: https://pbrobinson.fedorapeople.org/bcm283x-firmware-20150615-2.37600d5.fc22.src.rpm
Look at that license tag again. Almost there. ;)
Bah. SRPM: https://pbrobinson.fedorapeople.org/bcm283x-firmware-20150615-3.37600d5.fc22.src.rpm Spec url the same
Nice work. APPROVED.
spot: thanks a lot for the review New Package GIT Request ======================= Package Name: bcm283x-firmware Short Description: Broadcom bcm283x firmware for the Raspberry Pi Owners: pbrobinson pwhalen Branches: F-22 InitialCC:
Git done (by process-git-requests).