Bug 1232816

License should be: 

"ASL 2.0" 

see https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List for correct license Short Names


Source0 incorrect

https://github.com/kemitchell/%{github_name}/archive/%{github_name}-%{commit}.tar.gz

should be

https://github.com/kemitchell/%{github_name}/archive/%{commit}/%{github_name}-%{commit}.tar.gz

New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-2.fc22.src.rpm

Hi Zuzana,


It seems that this module needs to be built, see package.json:
  "scripts": {
    "build": "node build/parser.js > source/parser.generated.js",


The generated file is needed for proper functioning, see spdx.js:
source/spdx.js:var parser = require('./parser.generated.js').parser;


Building depends on npm(jison) which is not in Fedora yet.



Small other comment:
If you are targetting el6 than you have to change the ExclusiveArch:

%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif

If you are not buildinf for el6 then you can remove the 
%{?nodejs_find_provides_and_requires}
macro.

New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc22.src.rpm

Sources from npmjs don't contain build scripts, so it probably works without it.

Sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc23.src.rpm

I think you will have to generate the code from source, which will involve packaging jison.

https://lists.fedoraproject.org/archives/list/nodejs%40lists.fedoraproject.org/thread/YSBHPQXW2FTAVIEF4YUOY27HD5GEUIZB/

Some issues:

There is a missing dependency: spdx-exceptions


Version is missing in changelog

Check section incorrect, should be: defence README.md | replace-require-self | node

New versions license is MIT, not Apache

You can leave out the "Requires: npm(spdx-license-ids)" this is handled automatically

Any updates?

Are you still interested in packaging this module?

Sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.5.1-1.f26.src.rpm

The parser.generated.js file needs to be built this should be done in the %build section with:
node generate-parser.js > parser.generated.js

After it is built, it must be copied in the install section.

It does not have to be built in the %check section.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.