Bug 1232816 - Review Request: nodejs-spdx - SPDX License Expression Syntax parser
Summary: Review Request: nodejs-spdx - SPDX License Expression Syntax parser
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact:
URL:
Whiteboard:
Depends On: 1232777
Blocks: nodejs-reviews 1248428
TreeView+ depends on / blocked
 
Reported: 2015-06-17 14:32 UTC by Zuzana Svetlikova
Modified: 2018-07-30 09:16 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Zuzana Svetlikova 2015-06-17 14:32:15 UTC
Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-1.fc22.src.rpm
Description: SPDX License Expression Syntax parser
Fedora Account System Username: zvetlik

Comment 3 Piotr Popieluch 2015-08-02 16:39:37 UTC
Hi Zuzana,


It seems that this module needs to be built, see package.json:
  "scripts": {
    "build": "node build/parser.js > source/parser.generated.js",


The generated file is needed for proper functioning, see spdx.js:
source/spdx.js:var parser = require('./parser.generated.js').parser;


Building depends on npm(jison) which is not in Fedora yet.



Small other comment:
If you are targetting el6 than you have to change the ExclusiveArch:

%if 0%{?fedora} >= 19
ExclusiveArch: %{nodejs_arches} noarch
%else
ExclusiveArch: %{ix86} x86_64 %{arm} noarch
%endif

If you are not buildinf for el6 then you can remove the 
%{?nodejs_find_provides_and_requires}
macro.

Comment 4 Zuzana Svetlikova 2015-11-23 15:34:29 UTC
New sources:

Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx.spec
SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-spdx/nodejs-spdx-0.4.1-3.fc22.src.rpm

Sources from npmjs don't contain build scripts, so it probably works without it.

Comment 6 Piotr Popieluch 2015-11-24 07:52:39 UTC
I think you will have to generate the code from source, which will involve packaging jison.

https://lists.fedoraproject.org/archives/list/nodejs%40lists.fedoraproject.org/thread/YSBHPQXW2FTAVIEF4YUOY27HD5GEUIZB/

Comment 7 Piotr Popieluch 2015-11-24 21:04:14 UTC
Some issues:

There is a missing dependency: spdx-exceptions


Version is missing in changelog

Check section incorrect, should be: defence README.md | replace-require-self | node

New versions license is MIT, not Apache

You can leave out the "Requires: npm(spdx-license-ids)" this is handled automatically

Comment 8 Piotr Popieluch 2016-02-27 21:20:28 UTC
Any updates?

Comment 9 Piotr Popieluch 2016-09-28 21:27:55 UTC
Are you still interested in packaging this module?

Comment 11 Piotr Popieluch 2017-02-20 21:03:30 UTC
The parser.generated.js file needs to be built this should be done in the %build section with:
node generate-parser.js > parser.generated.js

After it is built, it must be copied in the install section.

It does not have to be built in the %check section.


Note You need to log in before you can comment on or make changes to this bug.