Bug 1232837

Summary:	OSC plugin isn't saving plan configuration values
Product:	Red Hat OpenStack	Reporter:	Jay Dobies <jason.dobies>
Component:	python-rdomanager-oscplugin	Assignee:	Lennart Regebro <lregebro>
Status:	CLOSED DUPLICATE	QA Contact:	yeylon <yeylon>
Severity:	urgent	Docs Contact:
Priority:	high
Version:	7.0 (Kilo)	CC:	akrivoka, bnemec, calfonso, jslagle, lregebro, mburns, ohochman, rhel-osp-director-maint, rlandy, srevivo
Target Milestone:	ga	Keywords:	Triaged
Target Release:	Director
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1232838 (view as bug list)		Environment:
Last Closed:	2015-06-30 14:53:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1232838

Description Jay Dobies 2015-06-17 15:27:22 UTC

Looking at:
https://github.com/rdo-management/python-rdomanager-oscplugin/blob/master/rdomanager_oscplugin/v1/overcloud_deploy.py#L364

This code is:

- Downloading the templates
- Generating the parameters to pass into the stack create
- Creating the stack

The plan is never updated in Tuskar, which means that if the user views the plan through the UI, it will show the defaults instead of what the user may have entered from the command line.

The process should be:

- Collect the parameters
- Update the plan configuration in Tuskar with the plan parameters
- Download the templates
- Create the stack

Comment 3 Lennart Regebro 2015-06-17 15:35:57 UTC

We were not planning to update the Tuskar plan with the deploy parameters, but use the already existing commands for that. Currently deploying will ignore the parameters in the Tuskar plan but I'm working on changing that:

See also: https://bugzilla.redhat.com/show_bug.cgi?id=1227873

There is also a patch to make it possible to load Tuskar parameters from a JSON file, but it's not required for this. 

https://bugzilla.redhat.com/show_bug.cgi?id=1227870

Comment 4 Dougal Matthews 2015-06-17 15:37:06 UTC

There is a review up that starts to move these defaults so they are sent to Tuskar when the undercloud is installed. https://review.gerrithub.io/#/c/236804/

This means that the defaults instack added will be visible in the UI and editable.

Comment 5 Lennart Regebro 2015-06-18 13:09:26 UTC

Patch for review: https://review.gerrithub.io/#/c/236804/

Comment 6 Mike Burns 2015-06-18 16:01:41 UTC

ON_DEV since the patch is posted for review

Comment 7 Jan Provaznik 2015-06-19 05:28:17 UTC

*** Bug 1233485 has been marked as a duplicate of this bug. ***

Comment 8 Lennart Regebro 2015-06-22 10:49:17 UTC

Another option is to set the deafaults in the Tuskar element, when installing:

https://review.openstack.org/#/c/193868/1

Comment 10 Mike Burns 2015-06-24 20:31:02 UTC

Ben/Lennart, 

Which patch(es) do we need?  I see 2 mentioned here:

https://review.gerrithub.io/#/c/236804/
https://review.openstack.org/#/c/193868/1

Comment 11 Ben Nemec 2015-06-24 21:01:39 UTC

AFAIK, that should do it.  Lennart wrote the patches though so probably best for him to confirm.

Comment 12 Lennart Regebro 2015-06-25 07:10:24 UTC

Yes, although this one is closely related as well: 

https://review.gerrithub.io/#/c/237311/1

It does the same change for scaling parameters so that they do not override the Tuskar settings.

Comment 13 Lennart Regebro 2015-06-30 14:53:16 UTC

This is the same issue, with the same fixes, as 1227873.

*** This bug has been marked as a duplicate of bug 1227873 ***