Bug 1233158

Summary:	Null pointer dreference in dht_migrate_complete_check_task
Product:	[Community] GlusterFS	Reporter:	Raghavendra G <rgowdapp>
Component:	distribute	Assignee:	Raghavendra G <rgowdapp>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	medium
Version:	3.7.1	CC:	amukherj, bugs, gluster-bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1233139
Clones:	1233517 (view as bug list)		Environment:
Last Closed:	2015-07-30 09:47:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1233139
Bug Blocks:	1233517

Description Raghavendra G 2015-06-18 10:58:17 UTC

+++ This bug was initially created as a clone of Bug #1233139 +++

Description of problem:

        if (gf_uuid_compare (stbuf.ia_gfid, tmp_loc.inode->gfid)) {
		gf_msg (this->name, GF_LOG_ERROR, 0,
                        DHT_MSG_GFID_MISMATCH,
		        "%s: gfid different on the target file on %s",
                        tmp_loc.path, dst_node->name);
                ret = -1;
		local->op_errno = EIO;
                goto out;
	}

        dst_node = dht_subvol_get_cached (this, tmp_loc.inode);

dst_node->name is accessed in the log, but dst_node is assigned later on.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-06-18 06:57:18 EDT ---

REVIEW: http://review.gluster.org/11313 (cluster/dht: Fix Null pointer dereference while logging) posted (#1) for review on master by Raghavendra G (rgowdapp)

Comment 1 Anand Avati 2015-06-19 05:20:38 UTC

REVIEW: http://review.gluster.org/11314 (cluster/dht: Fix Null pointer dereference while logging) posted (#2) for review on release-3.7 by Raghavendra G (rgowdapp)

Comment 2 Anand Avati 2015-07-07 04:58:57 UTC

COMMIT: http://review.gluster.org/11314 committed in release-3.7 by Vijay Bellur (vbellur) 
------
commit 92d0f5b11c6059b3516c14fd6cfdf1e407ea017f
Author: Raghavendra G <rgowdapp>
Date:   Thu Jun 18 16:23:50 2015 +0530

    cluster/dht: Fix Null pointer dereference while logging
    
    Change-Id: I1ea358b83267b0bcdf654ce18fe881fd4a6bf08d
    BUG: 1233158
    Signed-off-by: Raghavendra G <rgowdapp>
    Reviewed-on: http://review.gluster.org/11314
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: N Balachandran <nbalacha>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 3 Kaushal 2015-07-30 09:47:26 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user