Bug 1235747

Spec URL: https://lupinix.fedorapeople.org/review/nfft.spec
ARPM URL: https://lupinix.fedorapeople.org/review/nfft-3.3.0-2.fc21.src.rpm

Fixed documentation packaging

Spec URL: https://lupinix.fedorapeople.org/review/nfft.spec
SRPM URL: https://lupinix.fedorapeople.org/review/nfft-3.3.0-2.fc21.src.rpm

Koji builds:

Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=10213053
F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=10213060
F22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10213064

Hi Christian

It looks good :)

Cheers,
 Florian


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "MIT/X11 (BSD like)", "GPL (v2 or later)", "Unknown or
     generated". 9 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in nfft-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
   ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=10213343
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: nfft-3.3.0-2.fc23.x86_64.rpm
          nfft-devel-3.3.0-2.fc23.x86_64.rpm
          nfft-doc-3.3.0-2.fc23.noarch.rpm
          nfft-3.3.0-2.fc23.src.rpm
nfft.x86_64: W: spelling-error Summary(en_US) Nonequispaced -> Nonequivalent
nfft.x86_64: W: spelling-error %description -l en_US nonequispaced -> nonequivalent
nfft.x86_64: W: spelling-error %description -l en_US generalisations -> generalizations, generalization, generations
nfft.x86_64: W: shared-lib-calls-exit /usr/lib64/libnfft3.so.2.0.0 exit.5
nfft-devel.x86_64: W: only-non-binary-in-usr-lib
nfft-devel.x86_64: W: no-documentation
nfft.src: W: spelling-error Summary(en_US) Nonequispaced -> Nonequivalent
nfft.src: W: spelling-error %description -l en_US nonequispaced -> nonequivalent
nfft.src: W: spelling-error %description -l en_US generalisations -> generalizations, generalization, generations
nfft.src:22: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 22)
4 packages and 0 specfiles checked; 0 errors, 10 warnings.




Rpmlint (debuginfo)
-------------------
Checking: nfft-debuginfo-3.3.0-2.fc23.x86_64.rpm
nfft-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/nfft-3.3.0/kernel/nfsoft/nfsoft.c
nfft-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/nfft-3.3.0/kernel/nfsoft/wigner.c
nfft-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/nfft-3.3.0/kernel/nfsoft/wigner.h
1 packages and 0 specfiles checked; 0 errors, 3 warnings.





Rpmlint (installed packages)
----------------------------
nfft-devel.x86_64: W: only-non-binary-in-usr-lib
nfft-devel.x86_64: W: no-documentation
nfft-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/nfft-3.3.0/kernel/nfsoft/nfsoft.c
nfft-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/nfft-3.3.0/kernel/nfsoft/wigner.c
nfft-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/nfft-3.3.0/kernel/nfsoft/wigner.h
nfft.x86_64: W: spelling-error Summary(en_US) Nonequispaced -> Nonequivalent
nfft.x86_64: W: spelling-error %description -l en_US nonequispaced -> nonequivalent
nfft.x86_64: W: spelling-error %description -l en_US generalisations -> generalizations, generalization, generations
nfft.x86_64: W: shared-lib-calls-exit /usr/lib64/libnfft3.so.2.0.0 exit.5
4 packages and 0 specfiles checked; 0 errors, 10 warnings.

For the spurious-executable-perm warning see https://bugzilla.redhat.com/show_bug.cgi?id=467397#c4

Requires
--------
nfft-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    libnfft3.so.2()(64bit)
    nfft(x86-64)
    pkgconfig
    pkgconfig(fftw3)

nfft-doc (rpmlib, GLIBC filtered):

nfft (rpmlib, GLIBC filtered):
    /sbin/ldconfig
    libc.so.6()(64bit)
    libfftw3.so.3()(64bit)
    libm.so.6()(64bit)
    rtld(GNU_HASH)



Provides
--------
nfft-devel:
    nfft-devel
    nfft-devel(x86-64)
    pkgconfig(nfft3)

nfft-doc:
    nfft-doc

nfft:
    libnfft3.so.2()(64bit)
    nfft
    nfft(x86-64)



Source checksums
----------------
https://www-user.tu-chemnitz.de/~potts/nfft/download/nfft-3.3.0.tar.gz :
  CHECKSUM(SHA256) this package     : bb844b762896b17b7bf8245511a6372fcef82e55c2552f2f7ee7c65a8d746f30
  CHECKSUM(SHA256) upstream package : bb844b762896b17b7bf8245511a6372fcef82e55c2552f2f7ee7c65a8d746f30


Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1235747
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

===== Solution =====
      APPROVED

Thank you very much for the fast review!

New Package SCM Request
=======================
Package Name: nfft
Short Description: Nonequispaced fast Fourier transform
Upstream URL: https://www-user.tu-chemnitz.de/~potts/nfft/
Owners: lupinix
Branches: f21 f22 epel7

Git done (by process-git-requests).

nfft-3.3.0-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/nfft-3.3.0-2.fc22

nfft-3.3.0-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/nfft-3.3.0-2.fc21

nfft-3.3.0-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/nfft-3.3.0-2.el7

nfft-3.3.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository.

nfft-3.3.0-2.fc22 has been pushed to the Fedora 22 stable repository.

nfft-3.3.0-2.fc21 has been pushed to the Fedora 21 stable repository.

nfft-3.3.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository.