Spec URL: http://hg.et.redhat.com/misc/fedora-mingw--devel/?cmd=manifest;manifest=82a0662b5376fe1a90612ed85628670c902a43d3;path=/libpng/ SRPM URL: http://www.annexia.org/tmp/mingw/fedora-9/src/SRPMS/mingw32-libpng-1.2.31-5.fc9.src.rpm Description: MinGW Windows Libpng library
Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libpng/mingw32-libpng.spec SRPM URL: http://www.annexia.org/tmp/mingw/fedora-10/src/SRPMS/mingw32-libpng-1.2.31-5.fc10.src.rpm
I will review this package. current problems: - the latest version is not packaged (there is 1.2.34 in rawhide) rpmlint errors: mingw32-libpng.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libpng12.dll.a mingw32-libpng.noarch: W: spurious-executable-perm /usr/i686-pc-mingw32/sys-root/mingw/lib/libpng.dll.a mingw32-libpng.noarch: E: script-without-shebang /usr/i686-pc-mingw32/sys-root/mingw/lib/libpng12.la ^^^ I don't think we need libtool *la files installed, do we? Otherwise I don't see any other problem.
We do install *.la files for mingw32 packages because they are needed for libtool to link. This is mentioned in the packaging guidelines: http://fedoraproject.org/wiki/Packaging/MinGW#Libraries_.28DLLs.29 Here's an updated package: Spec URL: http://hg.et.redhat.com/cgi-bin/hg-misc.cgi/fedora-mingw--devel/file/tip/libpng/mingw32-libpng.spec SRPM URL: http://koji.fedoraproject.org/koji/getfile?taskID=1049093&name=mingw32-libpng-1.2.34-1.fc11.src.rpm * Tue Jan 13 2009 Richard W.M. Jones <rjones> - 1.2.34-1 - Rebase to 1.2.34 and patches from Fedora. - Requires pkgconfig. - Add documentation. Here is a Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1049092
I should add about the 'spurious-executable-perm' warning: libtool / gcc add executable permissions when they generate these files. In other words, this is not something that we are adding, but something that the tools are doing. It has to be said that we don't really understand why the tools do this, but at the same time we are loathed to change any details of the linking process since at the moment it works, but in the past it has proven quite fragile in that seemingly insignificant changes have broken things.
(In reply to comment #4) > I should add about the 'spurious-executable-perm' warning: > libtool / gcc add executable permissions when they generate > these files. In other words, this is not something that we > are adding, but something that the tools are doing. > > It has to be said that we don't really understand why the > tools do this, but at the same time we are loathed to change > any details of the linking process since at the moment it works, > but in the past it has proven quite fragile in that seemingly > insignificant changes have broken things. Well, I don't see any reason to have *dll.a files with executable perms but if it is created automatically leave it as is. Review: source files match upstream: YES package meets naming and versioning guidelines: YES specfile is properly named, is cleanly written and uses macros consistently: YES dist tag is present: YES build root is correct: YES license field matches the actual license: YES license is open source-compatible: YES latest version is being packaged: YES BuildRequires are proper: YES compiler flags are appropriate: YES %clean is present: YES package builds in mock (Rawhide/x86_64): YES rpmlint is silent: no, but warnings/errors are ok for mingw* package final provides and requires look sane: YES owns the directories it creates: YES doesn't own any directories it shouldn't: YES no duplicates in %files: YES file permissions are appropriate: well, as written in comment #4 it's ok code, not content: YES => reviewed
New Package CVS Request ======================= Package Name: mingw32-libpng Short Description: MinGW Windows Libpng library Owners: rjones berrange lfarkas Branches: EL-5 F-10 InitialCC:
cvs done.
Thanks everyone. I've built this for EL-5 and Rawhide, but cannot yet build it for F-10 because I'm waiting for the mingw32-zlib dependency to work its way into dist-f10-updates. I'll leave the bug open until then.
mingw32-libpng-1.2.34-2.fc10 has been submitted as an update for Fedora 10. http://admin.fedoraproject.org/updates/mingw32-libpng-1.2.34-2.fc10
mingw32-libpng-1.2.34-2.fc10 has been pushed to the Fedora 10 stable repository. If problems still persist, please make note of it in this bug report.