Bug 1235770
| Summary: | Consider removing brp-java-repack-jars-script | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Severin Gehwolf <sgehwolf> | ||||||
| Component: | redhat-rpm-config | Assignee: | Florian Festi <ffesti> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 25 | CC: | akurtako, dbhole, ffesti, jonathan, pmatilai | ||||||
| Target Milestone: | --- | Keywords: | Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | redhat-rpm-config-53-1.fc26 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2016-11-07 14:33:53 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Created attachment 1043467 [details]
Proposed spec file patch for F23 (rawhide)
Fixed up the previous patch which missed removing the script invocation in macros.
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle. Changing version to '23'. (As we did not run this process for some time, it could affect also pre-Fedora 23 development cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.) More information and reason for this action is here: https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23 Any thoughts about this? This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'. (In reply to Severin Gehwolf from comment #0) > Disclaimer: Addition of this script pre-dates me, but I think it's worth > doing some clean-up every once in a while. LOL, looking at the brp-* script histories it's easy to agree with that: * Wed Jan 22 2003 Elliot Lee <sopwith> 8.0.19-1 - Disable brp-implant-ident-static until it works everywhere * Thu Jan 16 2003 Nalin Dahyabhai <nalin> 8.0.18-1 - add brp-implant-ident-static, which requires mktemp As of today, it is still disabled... So yeah, if java people say brp-java-repack-jars is not needed anymore then who am I to disagree. I'll drop it out of the package but leave the actual source in git "just in case" for now. Done in redhat-rpm-config-53-1.fc26. Thanks for help on shedding another bit of historical cruft. |
Created attachment 1043200 [details] Proposed spec file patch for F23 (rawhide) Description of problem: brp-java-repack-jars script was once useful for updating timestamps in jar files since RPM gave errors at install time if the jars were identical but the date stamps of class files were different. I've had a conversation with Deepak Bhole and Alexander Kurtakov and both said it's no longer needed. Also that script was written at a time when java was multilib. That is no longer the case. Disclaimer: Addition of this script pre-dates me, but I think it's worth doing some clean-up every once in a while. Motivation for getting this script removed is faster Java builds. brp-java-repack-jars script slows down builds considerably if there are many jars produced during a build.