Bug 1235770 - Consider removing brp-java-repack-jars-script
Summary: Consider removing brp-java-repack-jars-script
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: redhat-rpm-config
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Florian Festi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-25 16:53 UTC by Severin Gehwolf
Modified: 2016-11-07 14:33 UTC (History)
5 users (show)

Fixed In Version: redhat-rpm-config-53-1.fc26
Clone Of:
Environment:
Last Closed: 2016-11-07 14:33:53 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed spec file patch for F23 (rawhide) (4.33 KB, patch)
2015-06-25 16:53 UTC, Severin Gehwolf
no flags Details | Diff
Proposed spec file patch for F23 (rawhide) (4.81 KB, patch)
2015-06-26 10:27 UTC, Severin Gehwolf
no flags Details | Diff

Description Severin Gehwolf 2015-06-25 16:53:17 UTC
Created attachment 1043200 [details]
Proposed spec file patch for F23 (rawhide)

Description of problem:
brp-java-repack-jars script was once useful for updating timestamps in jar files since RPM gave errors at install time if the jars were identical but the date stamps of class files were different. I've had a conversation with Deepak Bhole and Alexander Kurtakov and both said it's no longer needed. Also that script was written at a time when java was multilib. That is no longer the case.

Disclaimer: Addition of this script pre-dates me, but I think it's worth doing some clean-up every once in a while.

Motivation for getting this script removed is faster Java builds. brp-java-repack-jars script slows down builds considerably if there are many jars produced during a build.

Comment 1 Severin Gehwolf 2015-06-26 10:27:47 UTC
Created attachment 1043467 [details]
Proposed spec file patch for F23 (rawhide)

Fixed up the previous patch which missed removing the script invocation in macros.

Comment 2 Jan Kurik 2015-07-15 13:54:56 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 3 Severin Gehwolf 2016-03-22 12:54:24 UTC
Any thoughts about this?

Comment 4 Jan Kurik 2016-07-26 04:17:25 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 5 Panu Matilainen 2016-11-07 14:33:53 UTC
(In reply to Severin Gehwolf from comment #0)
> Disclaimer: Addition of this script pre-dates me, but I think it's worth
> doing some clean-up every once in a while.

LOL, looking at the brp-* script histories it's easy to agree with that:

* Wed Jan 22 2003 Elliot Lee <sopwith> 8.0.19-1
- Disable brp-implant-ident-static until it works everywhere

* Thu Jan 16 2003 Nalin Dahyabhai <nalin> 8.0.18-1
- add brp-implant-ident-static, which requires mktemp

As of today, it is still disabled...

So yeah, if java people say brp-java-repack-jars is not needed anymore then who am I to disagree. I'll drop it out of the package but leave the actual source in git "just in case" for now.

Done in redhat-rpm-config-53-1.fc26. Thanks for help on shedding another bit of historical cruft.


Note You need to log in before you can comment on or make changes to this bug.