Bug 1235990

Summary: quota: marker accounting miscalculated when renaming a file on with write is in progress
Product: [Community] GlusterFS Reporter: Vijaikumar Mallikarjuna <vmallika>
Component: quotaAssignee: Vijaikumar Mallikarjuna <vmallika>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.7.2CC: bugs, gluster-bugs, rgowdapp, smohan, storage-qa-internal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-3.7.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1235195 Environment:
Last Closed: 2015-07-30 09:51:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1235182, 1235195    
Bug Blocks: 1186580, 1202842, 1223636    

Comment 1 Vijaikumar Mallikarjuna 2015-06-26 10:13:08 UTC
Patch submitted: http://review.gluster.org/#/c/11425/

Comment 2 Anand Avati 2015-06-26 13:00:11 UTC
REVIEW: http://review.gluster.org/11425 (quota: marker accounting goes bad with rename while writing a file) posted (#2) for review on release-3.7 by Vijaikumar Mallikarjuna (vmallika)

Comment 3 Anand Avati 2015-07-02 11:26:50 UTC
COMMIT: http://review.gluster.org/11425 committed in release-3.7 by Raghavendra G (rgowdapp) 
------
commit 2bf6e683e88517c1b2c6c8b13ab681bfdb0acacc
Author: vmallika <vmallika>
Date:   Thu Jun 25 14:58:50 2015 +0530

    quota: marker accounting goes bad with rename while writing a file
    
    This is a backport of http://review.gluster.org/#/c/11403/
    
    > With below test-case, marker accounting becomes bad:
    > 1) Create a volume with 1 brick
    > 2) fuse mount
    > 3) on one terminal write some data
    >    dd if=/dev/zero of=f1 bs=1M count=500 oflag=sync
    > 4) on another terminal execute below rename operation while the write is
    > still in progress
    >     for i in {1..50}; do
    >         ii=`expr $i + 1`;
    >         mv f$i f$ii;
    >     done
    >
    > remove-xattr is already on while doing rename operation,
    > we should not be doing again in background when reducing the
    > parent size.
    >
    > Change-Id: I969a64bb559e2341315928b55b99203e9ddee3f2
    > BUG: 1235195
    > Signed-off-by: vmallika <vmallika>
    > Reviewed-on: http://review.gluster.org/11403
    > Tested-by: NetBSD Build System <jenkins.org>
    > Reviewed-by: Raghavendra G <rgowdapp>
    > Tested-by: Gluster Build System <jenkins.com>
    > Tested-by: Raghavendra G <rgowdapp>
    
    Change-Id: Ic37c7f7bd74093ee7e155b305834dbc1fdd24b10
    BUG: 1235990
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/11425
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Comment 4 Kaushal 2015-07-30 09:51:05 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user