Bug 1236489

Summary:	Keep the upstart libvirtd file to enable relaunching libvirt in case it goes down
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Oved Ourfali <oourfali>
Component:	vdsm	Assignee:	Yaniv Bronhaim <ybronhei>
Status:	CLOSED WONTFIX	QA Contact:	Jiri Belka <jbelka>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	3.5.3	CC:	983384190, bazulay, ecohen, fdeutsch, gklein, jbelka, lpeer, lsurette, oourfali, pstehlik, rhev-integ, virt-bugs, ybronhei, ycui, yeylon
Target Milestone:	---	Keywords:	ZStream
Target Release:	3.5.5
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	infra
Fixed In Version:	vdsm-4.16.21-1.el6ev	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1235350	Environment:
Last Closed:	2015-07-29 08:24:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Infra	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1233059, 1235350
Bug Blocks:

Comment 1 Fabian Deutsch 2015-06-30 07:55:47 UTC

I've tested that attached patch as follows:

1. Boot RHEV-H 6.7 (0609)
2. remount / rw
3. add upstart file and apply the patch
4. remount / ro
5. vdsm-tool configure --module libvirt --force
6. initctl status libvirtd
libvirtd start/running, process 15129
7. killall libvirtd
8. initctl status libvirtd
libvirtd start/running, process 16922

A new libvirt instance was spawned, to me this looks as if the bug is fixed with this and the Node side patch.

Comment 3 Jiri Belka 2015-07-09 09:06:36 UTC

ok, vdsm-4.16.21-1.el6ev.x86_64 (rhevh6 20150707.0.el6ev)

Jul  9 09:05:12 dell-r210ii-04 init: libvirtd main process (14898) killed by KILL signal
Jul  9 09:05:12 dell-r210ii-04 init: libvirtd main process ended, respawning

Comment 4 Yaniv Bronhaim 2015-07-09 09:29:53 UTC

After host reboot it won't work well with current vdsm code - Jiri, you can verify it as well and re-open for 3.5.5

Comment 5 Jiri Belka 2015-07-09 11:40:20 UTC

As mentioned in #4, libvirtd is not running when killed after the host was rebooted.

Comment 6 Yaniv Bronhaim 2015-07-29 08:24:12 UTC

This issue was raised by us when we found that RHEVH never ran libvirtd service with the upstart script - in 3.5.4 the fixes around it raised many regressions, in addition to that, this issue never came up as a bug by ovirt users so it can't be important enough to break other flows. I suggest to avoid this fix for 3.5. 
In next release which doesn't support el6 this issue is not relevant at all. 
I'm closing the bug unless someone thinks it worth fighting for.. If so, please review my suggested patch https://gerrit.ovirt.org/#/c/43227 and reopen the bug.