Bug 1235350 - Keep the upstart libvirtd file to make the flow similar to RHEL
Summary: Keep the upstart libvirtd file to make the flow similar to RHEL
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-node
Version: 3.5.3
Hardware: Unspecified
OS: Unspecified
high
unspecified
Target Milestone: ---
: 3.5.4
Assignee: Fabian Deutsch
QA Contact: Virtualization Bugs
URL:
Whiteboard: node
: 1235349 1239285 (view as bug list)
Depends On: 1233059
Blocks: 1059435 1236489 1250199
TreeView+ depends on / blocked
 
Reported: 2015-06-24 14:45 UTC by rhev-integ
Modified: 2016-02-10 20:07 UTC (History)
8 users (show)

Fixed In Version: ovirt-node-3.2.3-13.el7 ovirt-node-3.2.3-13.el6
Doc Type: Bug Fix
Doc Text:
Clone Of: 1233059
: 1236489 (view as bug list)
Environment:
Last Closed: 2015-09-03 17:55:07 UTC
oVirt Team: Node
Target Upstream Version:
Embargoed:
ylavi: Triaged+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1229227 0 high CLOSED Auto register rhevh6 to rhevm3.5.3 failed using management_server=$rhevm_ip:443 during the auto-install 2021-02-22 00:41:40 UTC
Red Hat Bugzilla 1236489 0 high CLOSED Keep the upstart libvirtd file to enable relaunching libvirt in case it goes down 2021-02-22 00:41:40 UTC
Red Hat Product Errata RHBA-2015:1733 0 normal SHIPPED_LIVE ovirt-node bug fix and enhancement update for RHEV 3.5.4 2015-09-03 21:54:11 UTC
oVirt gerrit 41979 0 master MERGED recipe: Keep the libvirtd upstart file. Never
oVirt gerrit 42817 0 ovirt-3.5 MERGED recipe: Keep the libvirtd upstart file. Never
oVirt gerrit 43143 0 ovirt-3.5 MERGED Bundle libvirtd.upstart Never

Internal Links: 1229227 1236489

Comment 2 Fabian Deutsch 2015-06-29 07:23:12 UTC
Yaniv, from 3.5.4 on RHEV-H will keep the libvirtd upstart file. IIRC there are also some adjustments on the vdsm side needed - specififc to RHEV-H - to use that file on RHEV-H.
Could you check if the upstart file will now be used on RHEV-H if available?

Comment 3 Yaniv Bronhaim 2015-06-29 07:41:26 UTC
Yep , https://gerrit.ovirt.org/#/c/42973/ removes the node restriction - without the explicit condition we will have libvirtd respawn also in el6 RHEV-H .
How do we verify it? should we have vdsm separate bug for that change?

Comment 4 Yaniv Bronhaim 2015-06-29 07:43:07 UTC
Oved, adding you to the needinfo about creating separate bugzilla question - as it is vdsm infra issue that should be handled in 3.5 scope.

Comment 5 Fabian Deutsch 2015-06-29 07:44:44 UTC
From the testing perspective I'd say yes to two bugs:

1. This node bug for ensuring that the upstart file is in place
2. vdsm bug to check that the logic is really restarting libvirtd in case it goes down.

Comment 6 Fabian Deutsch 2015-06-30 10:39:51 UTC
*** Bug 1235349 has been marked as a duplicate of this bug. ***

Comment 8 Fabian Deutsch 2015-07-06 12:11:17 UTC
*** Bug 1239285 has been marked as a duplicate of this bug. ***

Comment 9 Fabian Deutsch 2015-07-08 13:35:50 UTC
Test steps to test this bug:

(A)
1. Install RHEV-H manually
2. Register to RHEV-M 3.5 (from TUI side)
3. Setup storage, networking etc
4. Launch a VM, make sure it is launched correctly
5. Launch a second VM, make sure it is launched correctly.

Second test:
As in (A) but in 2.: Add from Engine side

Third test:
As in (A) but in 1.: Use auto-install + management_server (registration)

Fourth test:
As in (A) but in 1.: Use auto-install WITHOUT management_server and add from Engine side.

Comment 10 Fabian Deutsch 2015-07-08 13:38:58 UTC
In addition to comment 9: 

6. Put RHEV-H into maintenance mode and reboot
7. Make sure all VMs come up again afterwards

Comment 14 Ying Cui 2015-07-23 08:59:32 UTC
According to patches, the testing as following:

Test version:
# rpm -qa ovirt-node
ovirt-node-3.2.3-11.el6.noarch

# cat /etc/redhat-release 
Red Hat Enterprise Virtualization Hypervisor release 6.7 (20150717.0.el6ev)

# rpm -qa libvirt
libvirt-0.10.2-54.el6.x86_64

# ll /usr/share/doc/libvirt-0.10.2/libvirtd.upstart
-rw-r--r--. 1 root root 1181 2015-07-17 15:07 /usr/share/doc/libvirt-0.10.2/libvirtd.upstart

# ll /etc/init/libvirtd.conf
-rw-r--r--. 1 root root 1181 2015-07-23 07:28 /etc/init/libvirtd.conf


libvirtd.upstart already kept under /usr/share/doc/libvirt-0.10.2
and already copy to /etc/init/libvirtd.conf

Comment 15 Fabian Deutsch 2015-07-23 10:07:04 UTC
Before registration it should actually not be in /etc/init/libvirtd.conf

Ying, did you check the existence of /etc/init/libvirtd.conf before or after registration?

After a clean install libvirtd.conf should only be in /usr/share/doc/libvirt-0.10.2/libvirtd.upstart

Comment 16 Fabian Deutsch 2015-07-23 10:11:50 UTC
Let me correct myself: /etc/init/libvirtd.conf will be there, because vdsm-tool is installing it at boot time.

Comment 18 Ying Cui 2015-07-30 13:08:22 UTC
Fabian, now the vdsm bug 1236489 is closed as won't fix.
So we will verify this bug according to comment 14 on node side, OK?

Comment 19 Fabian Deutsch 2015-08-03 12:45:22 UTC
Ying, ok.

Comment 20 Ying Cui 2015-08-10 08:05:11 UTC
for patches on this bug, here only care rhevh 6.7, not impact rhevh 7.1.
according to to comment 14, comment 18 and comment 19, Verified this bug on rhevh 6.7.

Comment 22 errata-xmlrpc 2015-09-03 17:55:07 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1733.html


Note You need to log in before you can comment on or make changes to this bug.