Bug 1236596

Summary: heads-up opencv3 is comming
Product: [Fedora] Fedora Reporter: Jozef Mlich <jmlich>
Component: simonAssignee: Rex Dieter <rdieter>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 23CC: heri, hhorak, rdieter, vjancik
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-14 13:34:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1230078    
Attachments:
Description Flags
opencv includes should contain "opencv/"
none
simon-0.4.1-opencv3.patch
none
Spec file patch against simon 0.4.1-5 none

Description Jozef Mlich 2015-06-29 13:44:36 UTC
Created attachment 1044375 [details]
opencv includes should contain "opencv/"

Description of problem:
Simon package build is failing with OpenCV 3.0.0 See #1230078. 

The main reason seems to be incorrect path in #include directive. Currently it is #include <cv.h> and it should be #include <opencv/cv.h>. Similary with <highgui.h>.

Additionally, the detection of "BuilRequires: qt-webkit-devel" wasn't working correctly. I have added that manually into spec file.

I have tested this patch in my COPR repository:
https://copr-be.cloud.fedoraproject.org/results/jmlich/opencv3/fedora-22-x86_64/simon-0.4.1-5.fc23/

I wasn't able to find upstream bugzilla )-;

Comment 1 Jan Kurik 2015-07-15 13:53:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 3 Viktor Jancik 2015-08-14 10:25:37 UTC
Created attachment 1062970 [details]
simon-0.4.1-opencv3.patch

Separate patch file ready for inclusion.
I created it because the release tag got bumped and the spec file changed.

Comment 4 Viktor Jancik 2015-08-14 10:28:36 UTC
Created attachment 1062972 [details]
Spec file patch against simon 0.4.1-5

Comment 5 Viktor Jancik 2015-08-14 10:32:12 UTC
Created an upstream bug report:
https://bugs.kde.org/show_bug.cgi?id=351279

Comment 6 Rex Dieter 2015-08-14 13:04:32 UTC
Thanks, I'll try to take a closer look soon.

Comment 7 Rex Dieter 2015-08-14 13:22:56 UTC
This part is not needed

@@ -40,6 +41,7 @@ 
 BuildRequires: pkgconfig(qwt) >= 6
 BuildRequires: pkgconfig(samplerate)
 BuildRequires: qaccessibilityclient-devel
+BuildRequires: qt-webkit-devel


was fixed as part of bug #1240006 already

Comment 8 Rex Dieter 2015-08-14 13:34:57 UTC
%changelog
* Fri Aug 14 2015 Rex Dieter <rdieter> 0.4.1-6
- includes of opencv headers should contain "opencv/" (#1236596)