Bug 1230078 (opencv3) - OpenCV 3.1.0 is available
Summary: OpenCV 3.1.0 is available
Keywords:
Status: CLOSED RAWHIDE
Alias: opencv3
Product: Fedora
Classification: Fedora
Component: opencv
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Nicolas Chauvet (kwizart)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1236596 1238183 1238677 1238734 1238758 1241066 1246056 1246065 1254673 1254846 1315675 1329790 1333967 1334005
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-06-10 08:35 UTC by Jozef Mlich
Modified: 2016-06-06 01:02 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-06 01:02:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
changes in spec file (3.61 KB, patch)
2015-06-22 13:14 UTC, Jozef Mlich
no flags Details | Diff
changes in spec file (5.29 KB, patch)
2015-06-25 15:17 UTC, Jozef Mlich
no flags Details | Diff
git diff HEAD > opencv.spec.patch (10.02 KB, patch)
2016-04-21 04:22 UTC, Sergio Basto
no flags Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1114377 0 unspecified CLOSED opencv-2.4.9 available 2021-02-22 00:41:40 UTC

Internal Links: 1114377

Description Jozef Mlich 2015-06-10 08:35:50 UTC
Description of problem:
This is a tracking bug for new release. I have added OpenCV to Upstream Release Monitoring Tool, so those tracking bugs should be created automatically https://release-monitoring.org/project/6615/ in future.

Additionally, I was exploring what steps are required for package update in fedora rawhide. 

https://jmlich.fedorapeople.org/opencv-3.0.0-1.fc23.src.rpm
https://copr.fedoraproject.org/coprs/jmlich/playground/build/96947/

I didn't found "clean" version without 3rdparty directory. I wasn't able to compile it without this directory. 

I have added flag "-DWITH_IPP=OFF" into cmake to avoid download of IPP library . The patch to avoid static linking of _ts module (and _hal) is dropped. I don't know how to update cmake for dynamic linking. The CheckIPP() function is in one of those static modules.

I haven't made any research on impact of update to other packages, but it will be necessary to rebuild at least those packages
$ repoquery opencv\* --whatrequires --alldeps  --source | perl -pe 's/-\d.*?-\d+(\..*)?\.fc\d+(\..*)?.src.rpm//' | sort -u 
cinnamon
digikam
fawkes
ffmpeg
gmic
libfreenect
libkface
mlt
mrpt
opencv
OpenImageIO
php-facedetect
player
python-SimpleCV
shogun
simon

Comment 1 Nicolas Chauvet (kwizart) 2015-06-22 11:16:37 UTC
Any updates on this ? (WRT rebuild dependencies and failing status ?)
Also I would like to have a diff against the current spec file

Thx for your work on this.

Comment 2 Jozef Mlich 2015-06-22 13:14:23 UTC
Created attachment 1041833 [details]
changes in spec file

Comment 3 Nicolas Chauvet (kwizart) 2015-06-22 13:44:09 UTC
OK, I'm not sure about the removed patches, also the previous update (to opencv-2.4.11) has removed some patches that AFAIR was still needed (specially needed for building opencv dependencies).

If dependencies are failing, you might need to look as reintroducing some as they aren't merged upstream unfortunately.

Comment 4 Sergio Basto 2015-06-22 20:27:57 UTC
Hi, [1] I drop all patches because upstream already handle it , 
opencv already support gst1 IIRC [2], verifying again, seems to me, that was all upstreamed patches.  But all history is in git so we can get it back ...

Other subject and what bring me here . Looking here [3], we see 4 new bugs for F22 , so I'd like update Fedora 22 with opencv 2.4.11 instead the current 2.4.9, may I ?  

Thanks,

[1] http://pkgs.fedoraproject.org/cgit/opencv.git/commit/?id=d7da354e29b79aed069fbdf2dda54265f8ccff16 


[2] we got this comment:
# relevant gst1-related patches from upstream master branch

[3] https://apps.fedoraproject.org/packages/opencv/bugs/

Comment 5 Nicolas Chauvet (kwizart) 2015-06-22 21:08:38 UTC
(In reply to Sergio Monteiro Basto from comment #4)
> Hi, [1] I drop all patches because upstream already handle it , 
I'm more concerned about this patch:
>%patch0 -p1 -b .pkgcmake

Are we sure that all dependencies are rebuilding fine without it ?

Comment 6 Sergio Basto 2015-06-22 22:32:26 UTC
(In reply to Nicolas Chauvet (kwizart) from comment #5)
> I'm more concerned about this patch:
> >%patch0 -p1 -b .pkgcmake
> 
> Are we sure that all dependencies are rebuilding fine without it ?

ah, OpenCVGenPkgconfig.cmake now is completely different, so the patch is  unapplicable. But IIRC I checked and config now accept libdir variable etc, I think so [1] . 
Anyway I will check all dependencies soon. 

[1]
list(APPEND OpenCV_LIB_COMPONENTS_ "-L${libpath}") 


Thanks,

Comment 7 Sergio Basto 2015-06-24 14:33:39 UTC
As expect all [1] builds with opencv-devel-2.4.11-2.fc22.x86_64 without problem 

[1] 
digikam
f22.txt
fawkes
ffmpeg
frei0r-plugins
gmic
libfreenect
libkface
mlt
nomacs
opencfu
OpenImageIO
php-facedetect
player
simarrange
simon
vlc


May I proceed update f22 to opencv-devel-2.4.11-2 ?

Comment 8 Jozef Mlich 2015-06-25 15:17:57 UTC
Created attachment 1043181 [details]
changes in spec file

The attached patch contain also -contrib subpackage which goes from https://github.com/Itseez/opencv_contrib repository. It seems to be reasonable to ship them together.

I have also tried to recompile dependencies. I wasn't very successful so far. Here is a list:

cinnamon - didn't tried yet
libkface - failing #include <opencv/core/internal.hpp>; Using AlgorithmInfo and CV_INIT_ALGORITHM macro
digikam - failing dependency on libkface
player - failing cvQueryHistValue_1D, cvCvtPixToPlane was not declared in this scope
fawkes - failing depends on player
ffmpeg - rpmfusion/didn't tried
gmic -
 /usr/bin/ld: /tmp/cc4fIQuV.o: undefined reference to symbol 'cvWriteFrame'
 /usr/lib64/libopencv_videoio.so.3.0: error adding symbols: DSO missing from command line

libfreenect - ok
mlt - depeonds on rpmfusion/ffmpeg
mrpt - missing opencv2/legacy/legacy.hpp
OpenImageIO - didn't tried yet
php-facedetect - didn't tried yet
python-SimpleCV - didn't tried yet
shogun - didn't tried yet
simon - didn't tried yet

I inform you about my progress. I want to spent more time with this yet.

Comment 9 Sergio Basto 2015-06-25 21:26:05 UTC
(In reply to Sergio Monteiro Basto from comment #7)
> May I proceed update f22 to opencv-devel-2.4.11-2 ?

OK I think I'm authorized and I will update f22 with 2.4.11 first and before think about 3.0.0 . 

Anyway, about 3.0.0, the items nonfree are gone ? , we don't need anymore cleanup sources before upload it ? I check a little bit and don't found nonfree directory but if someone can confirm that, it would be good.

Thanks,

Comment 10 Sergio Basto 2015-06-26 11:53:26 UTC
Hi, 

(In reply to Jozef Mlich from comment #8)
> Created attachment 1043181 [details]
> changes in spec file
> 
> The attached patch contain also -contrib subpackage which goes from
> https://github.com/Itseez/opencv_contrib repository. It seems to be
> reasonable to ship them together.
> 
> I have also tried to recompile dependencies. I wasn't very successful so
> far. Here is a list:
> 
> cinnamon - didn't tried yet

As mention in bug #1114377#c33 , we don't need rebuild packages that only depends on opencv-python , we just need test it :) 

> libkface - failing #include <opencv/core/internal.hpp>; Using AlgorithmInfo
> and CV_INIT_ALGORITHM macro
> digikam - failing dependency on libkface
> player - failing cvQueryHistValue_1D, cvCvtPixToPlane was not declared in
> this scope
> fawkes - failing depends on player
> ffmpeg - rpmfusion/didn't tried
> gmic -
>  /usr/bin/ld: /tmp/cc4fIQuV.o: undefined reference to symbol 'cvWriteFrame'
>  /usr/lib64/libopencv_videoio.so.3.0: error adding symbols: DSO missing from
> command line
> 
> libfreenect - ok
> mlt - depends on rpmfusion/ffmpeg
> mrpt - missing opencv2/legacy/legacy.php
> OpenImageIO - didn't tried yet
> php-facedetect - didn't tried yet
> python-SimpleCV - didn't tried yet
> shogun - didn't tried yet
> simon - didn't tried yet
> 
> I inform you about my progress. I want to spent more time with this yet.

I can take care about rpmfusion package i.e. mlt , ffmpeg and vlc. 
While I'm writing here, I'm think that we can use copr

Comment 11 Sergio Basto 2015-06-26 11:55:41 UTC
Hi, 

(In reply to Jozef Mlich from comment #8)
> Created attachment 1043181 [details]
> changes in spec file
> 
> The attached patch contain also -contrib subpackage which goes from
> https://github.com/Itseez/opencv_contrib repository. It seems to be
> reasonable to ship them together.
> 
> I have also tried to recompile dependencies. I wasn't very successful so
> far. Here is a list:
> 
> cinnamon - didn't tried yet

As mention in bug #1114377#c33 , we don't need rebuild packages that only depends on opencv-python , we just need test it :) 

> libkface - failing #include <opencv/core/internal.hpp>; Using AlgorithmInfo
> and CV_INIT_ALGORITHM macro
> digikam - failing dependency on libkface
> player - failing cvQueryHistValue_1D, cvCvtPixToPlane was not declared in
> this scope
> fawkes - failing depends on player
> ffmpeg - rpmfusion/didn't tried
> gmic -
>  /usr/bin/ld: /tmp/cc4fIQuV.o: undefined reference to symbol 'cvWriteFrame'
>  /usr/lib64/libopencv_videoio.so.3.0: error adding symbols: DSO missing from
> command line
> 
> libfreenect - ok
> mlt - depends on rpmfusion/ffmpeg
> mrpt - missing opencv2/legacy/legacy.php
> OpenImageIO - didn't tried yet
> php-facedetect - didn't tried yet
> python-SimpleCV - didn't tried yet
> shogun - didn't tried yet
> simon - didn't tried yet
> 
> I inform you about my progress. I want to spent more time with this yet.

I can take care about rpmfusion packages i.e. mlt , ffmpeg and vlc. 
While I'm writing here, I'm thinking that we can use copr

Comment 12 Sergio Basto 2015-06-27 16:49:16 UTC

I build opencv-3.0.0-1 with my spec, I forgot added yours opencv_contrib, sorry .

https://copr.fedoraproject.org/coprs/sergiomb/opencv/builds/

so far only simon failed , player succeeded  ...

Comment 13 Sergio Basto 2015-06-27 20:54:17 UTC
(In reply to Sergio Monteiro Basto from comment #12)

> https://copr.fedoraproject.org/coprs/sergiomb/opencv/builds/

Sorry opencv-3.0.0-1 was removed from buildroot and I got false positives. 

After reinsert opencv-3.0.0 in buildroot, this ones [1] fails to build, should we open bugs against those components ?

Thanks, 

[1] 
player
opencfu 
gmic
frei0r-plugins
libkface

Comment 14 Jozef Mlich 2015-06-29 14:12:18 UTC
I had also troubles with simon. I have created an patch and bug for its component #1236596.

Comment 15 Jozef Mlich 2015-07-01 11:29:40 UTC
The patch for player package is attached in #1238183.

Comment 16 Sergio Basto 2015-07-01 21:46:50 UTC
Hi,  
It still have this 6 and digikam which depends on libfake .

opencfu [1] 
In file included from src/processor/src/Predictor.cpp:1:0:
src/processor/headers/Predictor.hpp:23:9: error: 'CvRTrees' does not name a type
         CvRTrees m_trees;

gmic [2] 
/usr/bin/ld: /tmp/cckWdv8g.o: undefined reference to symbol 'cvWriteFrame'
/lib/libopencv_videoio.so.3.0: error adding symbols: DSO missing from command line

frei0r-plugins [3] 
filter/facedetect/facedetect.cpp:267:9: error: could not convert '{{cvRound((((FaceDetect*)this)->FaceDetect::color[4].f0r_param_color::r * 2.55e+2f)),

libkface [4] 
./libopencv.h:55:37: fatal error: opencv2/core/internal.hpp: No such file or directory
compilation terminated.

simarrange [5] 
/usr/bin/ld: /tmp/ccSDJuLu.o: undefined reference to symbol 'cvSaveImage'
/usr/lib64/libopencv_imgcodecs.so.3.0: error adding symbols: DSO missing from command line

fawkes [6]
  error: 'threshold' is not a member of 'cv'

[1] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/opencfu-3.8.11-3.fc22/build.log.gz

[2] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-i386/gmic-1.6.2.0-1.fc22/build.log.gz

[3] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/frei0r-plugins-1.4-3.fc22/build.log.gz

[4] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/libkface-15.04.0-1.fc22/build.log.gz

[5] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/simarrange-0.0-5.20140729git9500190.fc22/build.log.gz

[6] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/fawkes-0.5.0-20.fc22/build.log.gz

Comment 17 Jozef Mlich 2015-07-02 11:59:29 UTC
It seems, the /usr/include/opencv/cv.h is not reachable during fawkes compilation. I have modified #include <cv.h> to #include <opencv/cv.h> and it is working now. See #1238677.

Comment 18 Jozef Mlich 2015-07-02 13:44:31 UTC
I have prepared patch for gmic as well. See #1238734

Comment 19 Jozef Mlich 2015-07-02 14:37:55 UTC
I have prepared patch for simarrange. See #1238758

Comment 20 Sergio Basto 2015-07-04 12:27:28 UTC
Hi, Jozef Mlich ,
if you like the idea you may ask permissions to my opencv mass builder [1] 
to build the packages in the same place. 

We also need test dependencies of opencv-devel: shogun , shogun-devel depends on opencv-devel  doesn't seems to me very logical . Maybe shogun doesn't need it anymore .

And test dependencies of opencv-python: cinnamon and python-SimpleCV 


[1] https://copr.fedoraproject.org/coprs/sergiomb/opencv/permissions/

Thanks,

Comment 21 Jozef Mlich 2015-07-08 11:39:50 UTC
I have prepared patch for frei0r-plugins. See #1241066

Comment 22 Sergio Basto 2015-07-10 16:45:44 UTC
Hi, Cool.
 
I updated copr sergiomb/opencv [1] and rebuilt all for F22 and rawhide 

libkface [4], seems to me,  the major show stopper to begin to test the big Digikam . I will begin tests with ffmpeg , vlc and mlt .

I tried do some investigation on libkface [5] this ./libopencv.h includes internal.hpp that doesn't exist in opencv-3 !? 


[1] https://copr.fedoraproject.org/coprs/sergiomb/opencv/builds/ 

[4] https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-22-x86_64/libkface-15.04.0-1.fc22/build.log.gz

[5] ./libopencv.h:55:37: fatal error: opencv2/core/internal.hpp: No such file or directory
compilation terminated.

Comment 23 Jozef Mlich 2015-07-13 07:48:50 UTC
By the way, there is an guide for migration to 3.0.0 [1]. I was looking into its code. It seems there is some problem with #includes. I have omitted that internal.h. 

Next, libkface is using CV_INIT_ALGORITHM macro. It should be used differently in new version. I am not sure how to rewrite that part.

[1] http://docs.opencv.org/master/db/dfa/tutorial_transition_guide.html

Comment 24 Jan Kurik 2015-07-15 14:02:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 25 Jozef Mlich 2015-07-23 11:57:34 UTC
In my opinion, this bug should be tracked against rawhide.

I have created tracking bug for libkface #1246056. There is already bug in libkface upstream https://bugs.kde.org/show_bug.cgi?id=349601 .

Comment 26 Jozef Mlich 2015-07-23 12:12:57 UTC
I have created tracking bug for opencfu #1246065. The problem here seems to be non-trivial.

Comment 27 Sergio Basto 2015-07-23 14:38:14 UTC
OK, I agree with everything, for these two packages maybe contact the upstream could be the solution, sometimes they release a new version with support of updated libraries.

Thanks,

Comment 29 Jozef Mlich 2015-08-18 10:03:48 UTC
There is an patch for libkface. https://bugsfiles.kde.org/attachment.cgi?id=94088 . Digikam needs patch yet.

../../../../extra/kipi-plugins/removeredeyes/plugin/libopencv.h:62:37: fatal error: opencv2/legacy/compat.hpp: No such file or directory

Comment 30 Sergio Basto 2015-08-18 13:51:50 UTC
Hi,
We may learn something from this new patch for example, the patch got : 

-#include <opencv2/legacy/compat.hpp>

:)

Comment 31 Sergio Basto 2015-08-18 22:13:25 UTC
Hi, 
I'm rebuilding all packages in copr.fedoraproject.org/coprs/sergiomb/opencv 
because I want builds for F21 and for F23 and I had to restart it (again) because I'm bumping releases versions of packages for dnf update , really updates the package, if we enable sergiomb/opencv ...

Best regards.

Comment 32 Sergio Basto 2015-08-19 03:28:23 UTC
Hi, Viktor

Following bug #1254673 , I saw that you build successfully Digikam in copr , you may use  copr.fedoraproject.org/coprs/sergiomb/opencv , you just need ask permissions on copr page (I will give you ) . 

IMHO we should use same opencv src.rpm , could you share patch 6 [1] ? please. 
For add to my opencv-3.0.0.src.rpm and in a near future, I may commit it in rawhide, when all deps are solved and we are comfortable to move on. 

Thanks,

BTW you can takeover all my work in this process, I would be grateful, we need open bugs in all FTBFS packages: mrpt  opencfu, shogun [2] . 

[1] Patch #6 (opencv-3.0.0-pngdir.patch):
+ /usr/bin/cat /builddir/build/SOURCES/opencv-3.0.0-pngdir.patch
+ /usr/bin/patch -p1 -b --suffix .pngdir --fuzz=0

[2] https://copr.fedoraproject.org/coprs/vjancik/opencv3-deps/monitor/

Comment 33 Viktor Jancik 2015-08-19 03:44:43 UTC
Hi, Sergio

I requested build permissions to your copr repository some time ago. But now that I have it all setup, I will finish the process in my copr. I hope you don't mind.

The Patch6 is useless. It was my mistake, it doesn't fix anything, just changes the build log a little. I just didn't remove it yet, because I wanted to maintain a clean reference of what built with what. I will remove it and rebuild opencv and all the deps when all the deps are fixed.

The spec file changes compared to yours are non-negligible though.

As for the remaining packages, I am working on it.

Comment 34 Sergio Basto 2015-08-19 03:53:58 UTC
OK, no problem, work as you like. 

I gave you permissions now , I think, I missed the notification :/

I uploaded my opencv.spec to https://sergiomb.fedorapeople.org/opencv/ 

Thanks,

Comment 35 Viktor Jancik 2015-09-04 11:26:27 UTC
Status:

Digikam and libkface will get patched upstream in the 4.14.0 release as reported here:
https://bugs.kde.org/show_bug.cgi?id=349601

The release date for 4.14.0 is 27/09/2015 as can be seen here:
https://www.digikam.org/about/releaseplan

OpenCFU fix is stagnating, upstream doesn't seem to be coming through:
https://github.com/qgeissmann/OpenCFU/issues/17

and lastly mrpt compatibility with OpenCV 3 should be fixed in version 1.3.0 (a released version), I filed a bug asking for update, but it seems there is no update yet:
https://bugzilla.redhat.com/show_bug.cgi?id=1254846


Since digikam and libkface patches were tested by two users and both reported at least comparable results to previous versions, and I can update mrpt personally, the only thing that remains is OpenCFU, but we could be waiting for that indefinitely.

My question therefore is, should we proceed with updating OpenCV 3 in Rawhide now, with broken OpenCFU? Or wait until 27/09/2015 or wait even longer?

Thank you for your feedback.

Comment 36 Sergio Basto 2015-09-05 02:38:46 UTC
bugs #1238677,  #1238734,  #1241066,  #1246056,  #1246065,  #1254673 and #1254846 are fixed in rawhide ?

Comment 37 Sergio Basto 2015-09-05 02:44:45 UTC
I had test ffmpeg . vlc and mlt (packages from rpmfuison ) and vlc which needs ffmpeg built with OpenCV 3.0.0 , is FTBFS .

Comment 38 Nicolas Chauvet (kwizart) 2015-09-05 07:12:27 UTC
According that the opencv-3.0.0 work is rawhide/f24 only (and few packages are still missing to build) I would wait after f23 GA to make the update. Specially as 3rd part repo aren't ready even for f23. (I hope that f23 will be made at the same time as f24 there).

I also remember a question about few dependencies that were not enabled in the opencv build (eigen, etc). that was because I do not use theses and it makes grow opencv when used by ffmpeg (which is a core multimedia package that do not need to have any corner case dependencies installed by default). ffmpeg should only install opencv-core for this purpose.

I would be interested if someone can point me the current update patch, in browsable form (cgit)

Thx for your work on this.

Comment 39 andre 2015-10-13 15:34:02 UTC
Hi,

could you update OpenCV 2.4 to its latest release[1] (currently 2.4.12.2)
till the problems with OpenCV 3 are fixed.

Newer releases install additional header files to simplify transition to 3.0.

Thanks


[1] https://github.com/Itseez/opencv/releases

Comment 40 Sergio Basto 2016-01-07 20:37:13 UTC
OpenCV 3.1 is available .

Today I was able to build digikam 5.0.0-0.1.beta2.fc23 

In copr [1] I have built all deps, except: 
- OpenCFU #1246065 but seems that have fixes [2]
- fawkes #1238677 seems we have one workaround 
- mrpt  1.3.2-1.fc24 failed to build. 


[1] https://copr.fedoraproject.org/coprs/sergiomb/opencv/builds/ 
[2] https://github.com/qgeissmann/OpenCFU/tree/opencv3_compat

Comment 41 Pavel Kajaba 2016-02-25 10:28:07 UTC
There seems to be an update for OpenCFU #1246065 [1].

[1] https://github.com/qgeissmann/OpenCFU/issues/17

Comment 42 Sergio Basto 2016-03-17 02:00:59 UTC
(In reply to Pavel Kajaba from comment #41)
> There seems to be an update for OpenCFU #1246065 [1].
> 
> [1] https://github.com/qgeissmann/OpenCFU/issues/17

Pavel Kajaba, Viktor Jancik and Jozef Mlich, please test and update Opencv-3.1  in rawhide . I gave you permission to build in copr [1], but until today I don't had a new build. Have you test anything ? or have you another copr project ? 

Package OpenCFU is orphan and I have to reduce my projects, could you take care of opencv  ? 


[1] https://copr.fedorainfracloud.org/coprs/sergiomb/opencv/

Comment 43 Jozef Mlich 2016-03-17 07:37:33 UTC
I am sorry, I haven't found time for that since I am not working for Red Hat anymore. Thanks for that reminder. I will try to find some time. 

As far as I remember there were quite a lot activity in upstream digikam package to fix compatibility with OpenCV 3, but in your copr it is still failing. https://bugs.kde.org/show_bug.cgi?id=349601

Comment 44 Pavel Kajaba 2016-03-17 09:34:35 UTC
I am on PTO.

I will look into it.

Comment 45 Sergio Basto 2016-04-01 15:40:07 UTC
Checking deps of opencv again we got: 

cinnamon updates
digikam updates
fawkes updates
frei0r-plugins fedora
gmic updates-testing
gstreamer1-plugins-bad-free updates
kf5-libkface updates-testing
libfreenect updates
libkface fedora
mrpt fedora
nomacs updates
opencfu fedora
OpenImageIO updates
os-autoinst updates
php-facedetect fedora
player fedora
python-SimpleCV fedora
shogun updates
simarrange fedora
simon fedora

lives @System
ffmpeg rpmfusion-free-updates-testing
mlt rpmfusion-free-updates-testing
vlc rpmfusion-free-updates-testing

gstreamer1-plugins-bad-free is new , isn't it ? but from what I saw in https://copr.fedorainfracloud.org/coprs/sergiomb/opencv/builds/ almost all packaged are ready for opencv3 , so may be we may compile it for rawhide (f25) , what you you think ?

Comment 46 Sergio Basto 2016-04-04 15:26:22 UTC
Kwizart ,  Pavel Kajaba wrote me directly, I think he agree we move to opencv3 in f25 , but doesn't have write access , I don't have admin access can you approve us in https://admin.fedoraproject.org/pkgdb/package/rpms/opencv/ ? 
Thanks

Comment 47 Pavel Kajaba 2016-04-04 18:50:53 UTC
yeah, it would be great. 

Also I am curious about OpenCV dependencies - i have worked while on fixing dependent packages but isn't it work for maintainers of these packages?

Comment 48 Sergio Basto 2016-04-04 22:20:36 UTC
(In reply to Pavel Kajaba from comment #47)
> yeah, it would be great. 
> 
> Also I am curious about OpenCV dependencies - i have worked while on fixing
> dependent packages but isn't it work for maintainers of these packages?

You should report it like what we have in "Depends On" field :  
Depends On: 	1238677 1238734 1241066 1246056 1246065 1236596 1238183 1238758 1254673 1254846 (edit)

Comment 49 Jozef Mlich 2016-04-05 05:43:57 UTC
We were looking into compatibility with other packages and compiling issues so far. As far as I remember, the source file was containing 3rd party packages (bundling policy/recommendation) and more important legal problematic content.

In case of packages similar to opencv, I we seen an bash script with following code in dist git:
wget http..opencv-version.tar.gz
rm -rf ./3rdparty/
patch < Makefile-3rparty.patch
tar czf opencv-version-clean.tar.gz

Please don't forget to do that before pushing new opencv to fedora.

Comment 50 Pavel Kajaba 2016-04-05 06:37:27 UTC
Thanks for commit acces!

I have seen too scripts like that, but I am curious about dependent packages.

They are usually fixed in upstream and can compile without problem,but official releases can't be compiled.

Could we release git release or it's better to patch it out from commits?

Comment 51 Sergio Basto 2016-04-05 12:01:15 UTC
(In reply to Jozef Mlich from comment #49)

> In case of packages similar to opencv, I we seen an bash script with
> following code in dist git:
> wget http..opencv-version.tar.gz
> rm -rf ./3rdparty/
> patch < Makefile-3rparty.patch
> tar czf opencv-version-clean.tar.gz
> 
> Please don't forget to do that before pushing new opencv to fedora.

IIRC, I think we don't need do this clean on opencv-3.1.0, nonfree code have been removed upstream, if not,  we already should do that in copr . 
But we can add rm -rf ./3rdparty/ in spec , just to make sure that bundle sources aren't used. 

But first , we need a big announce of heads up in fedora devel Mailing list, anyone do this ?  


I grab opencv-3.1.0-1.fc25.src.rpm from copr [1] , I will do some cleans and send again to copr 


[1] wget https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-rawhide-x86_64/00171543-opencv/opencv-3.1.0-1.fc25.src.rpm

Thanks.

Comment 52 Jozef Mlich 2016-04-05 12:42:50 UTC
(In reply to Sergio Monteiro Basto from comment #51)

> > In case of packages similar to opencv, I we seen an bash script with
> > following code in dist git:
> > wget http..opencv-version.tar.gz
> > rm -rf ./3rdparty/
> > patch < Makefile-3rparty.patch
> > tar czf opencv-version-clean.tar.gz
> IIRC, I think we don't need do this clean on opencv-3.1.0, nonfree code have
> been removed upstream, if not,  we already should do that in copr . 
> But we can add rm -rf ./3rdparty/ in spec , just to make sure that bundle
> sources aren't used. 

I am not sure if this is enough for fedora guidelines. I would rather avoid have legal problematic files in srpm.

Don't forget also on #1295173
[jmlich@jmlich-hp opencv-3.1.0]$ find . |grep lena
./modules/java/common_test/res/drawable/lena.png
./doc/tutorials/introduction/clojure_dev_intro/images/lena.png
./doc/tutorials/introduction/biicode/images/bii_lena.png
./doc/tutorials/introduction/desktop_java/images/lena.png
./samples/data/lena_tmpl.jpg
./samples/data/lena.jpg
./samples/java/clojure/simple-sample/resources/images/lena.png


> But first , we need a big announce of heads up in fedora devel Mailing list,
> anyone do this ?  

It would be nice if you or Petr Kajaba can write anouncement on fedora devel list. There is also some process to add this feature to 
https://fedoraproject.org/wiki/Releases/24/ChangeSet

> I grab opencv-3.1.0-1.fc25.src.rpm from copr [1] , I will do some cleans and
> send again to copr 

> [1] wget
> https://copr-be.cloud.fedoraproject.org/results/sergiomb/opencv/fedora-
> rawhide-x86_64/00171543-opencv/opencv-3.1.0-1.fc25.src.rpm
> 
> Thanks.

Comment 53 Pavel Kajaba 2016-04-06 07:29:25 UTC
I have sent email to fedora-devel today.

Comment 54 Sergio Basto 2016-04-21 00:56:36 UTC
Hello,

I built 3.1.0-2 in copr , with last changes of opencv.spec in F23+ 

* Wed Apr 20 2016 Sérgio Basto <sergio> - 3.1.0-2
- Add aarch64 and ppc64le to list of architectures where TBB is supported (#1262788).
- Use bcond tags to easily enable or disable modules.
- Fixed unused-direct-shlib-dependency in cmake with global optflags.
- Added README.md with references to online documentation.
- Investigation on the documentation, added a few notes.

http://copr-dist-git.fedorainfracloud.org/cgit/sergiomb/opencv/opencv.git/tree/opencv.spec
http://copr-dist-git.fedorainfracloud.org/cgit/sergiomb/opencv/opencv.git/commit/opencv.spec?id=296be48bafec9525c04b499aa05e307b2d8f0d32

http://copr-dist-git.fedorainfracloud.org/cgit/sergiomb/opencv/opencv.git/commit/opencv.spec?id=f4ee2a137ae4900f53ad2e649635e93ad885c85e

but we still need unbundle 3rdparty/libwebp , build doesn't go without 3rdparty/libwebp, when this is done , I'm ready to commit opencv-3.1 in rawhide. 

Best regards.

Comment 55 Sergio Basto 2016-04-21 04:22:13 UTC
Created attachment 1149283 [details]
git diff HEAD > opencv.spec.patch

(In reply to Sergio Monteiro Basto from comment #54)

> but we still need unbundle 3rdparty/libwebp , build doesn't go without
> 3rdparty/libwebp, when this is done , I'm ready to commit opencv-3.1 in
> rawhide. 

To unbundle libwebp, we just need add BR: libwebp-devel, so I think we may commit and build in rawhide , just rawhide for now , just after all deps solved, we should move to F24, IMHO. 
In attachment the propose of changes for rawhide .

Comment 56 Sergio Basto 2016-04-27 01:51:43 UTC
Hello, 
To check the broken deps that still on rawhide, we may do this little script: 

wget https://kojipkgs.fedoraproject.org/compose/rawhide/latest-Fedora-/logs/x86_64/repoclosure-Everything.x86_64.log -qO- | grep package -A2 | grep opencv -B2 | grep package

I know, for example, os-autoinst was submit to rawhide but still not there , so please check before request to someone to rebuild his package. 

Pavel Kajaba and Jozef Mlich , about the other tasks like clean problematic content , avoid have legal problematic files in srpm, ask for rebuild etc , you may do it, be my guess ;-) .

Thanks

Comment 57 Vasiliy Glazov 2016-04-28 11:24:25 UTC
opencv-devel-3.1.0-3.fc25.x86_64.rpm package missed file /usr/lib64/pkgconfig/opencv.pc (in opencv 2.4 this file present).
As a result opencv not visible for pkgconfig and can'conpile ffmpeg.

Comment 58 Pavel Kajaba 2016-04-28 11:30:36 UTC
Are you sure?

$ wget https://kojipkgs.fedoraproject.org//packages/opencv/3.1.0/3.fc25/x86_64/opencv-devel-3.1.0-3.fc25.x86_64.rpm
$ rpm -qpl opencv-devel-3.1.0-3.fc25.x86_64.rpm | grep opencv.pc

returns /usr/lib64/pkgconfig/opencv.pc

Comment 59 Vasiliy Glazov 2016-04-28 11:34:50 UTC
Sorry, my mistake.

What you can say about this error http://koji.russianfedora.pro/kojifiles/work/tasks/4865/74865/build.log ?

Problem in ffmpeg?

Comment 60 Rex Dieter 2016-04-28 17:01:36 UTC
Most likely an ffempg problem, depends on what's in ffmpeg's configure script exactly.

Comment 61 Pavel Kajaba 2016-04-28 17:31:06 UTC
Have you tried to ping them on their IRC?

Comment 62 Sergio Basto 2016-05-04 01:14:09 UTC
Checking broken deps today we still got : 

fawkes
frei0r
gstreamer1-plugins-bad-free
mrpt
nomacs
opencfu
php-facedetect
simarrange

Checking how things are going, I saw mrpt fails with vtk something , I in opencv-3.1.0-3.fc25, I had disable VTK support, preferring enable Qt5 support [1] 
Now I have this dilemma, what I should enable VTK or Qt5 ?



[1] 
- Remove BR: vtk-devel because VTK support is disabled. Incompatible combination: OpenCV + Qt5 and VTK ver.6.2.0 + Qt4

Comment 63 Sergio Basto 2016-05-04 15:07:37 UTC
(In reply to Sergio Monteiro Basto from comment #62)

> Now I have this dilemma, what I should enable VTK or Qt5 ?

Correction : Should we enable VTK or Qt5 ?

and I enabled VTK not a long time ago, so I felt confident in disable it ... 

Another subject, from http://docs.opencv.org/3.1.0/db/dfa/tutorial_transition_guide.html

we may read that contrib repository is a place for all new, experimental and non-free algorithms.

./modules/xfeatures2d/src/sift.cpp
./modules/xfeatures2d/perf/perf_surf.cpp
./modules/xfeatures2d/src/surf.cpp

now are in contrib repository it must be cleaned !

Comment 64 Sergio Basto 2016-05-08 01:07:19 UTC
(In reply to Sergio Monteiro Basto from comment #63)

> we may read that contrib repository is a place for all new, experimental and
> non-free algorithms.
> 
> ./modules/xfeatures2d/src/sift.cpp
> ./modules/xfeatures2d/perf/perf_surf.cpp
> ./modules/xfeatures2d/src/surf.cpp
> 
> now are in contrib repository it must be cleaned !

Reading https://github.com/Itseez/opencv_contrib/blob/master/modules/README.md , we got in point 19 - opencv_xfeatures2d: Extra 2D Features Framework containing experimental and non-free 2D feature algorithms. And seems be the only non-free software. So I had submit a new build where is removed opencv_xfeatures2d module from the source of opencv_contrib => opencv_contrib-clean-3.1.0.tar.gz

http://koji.fedoraproject.org/koji/buildinfo?buildID=760682

Comment 65 Sergio Basto 2016-05-10 18:57:00 UTC
(In reply to Sergio Monteiro Basto from comment #64)
> So I had submit a new build where is removed
> opencv_xfeatures2d module from the source of opencv_contrib =>
> opencv_contrib-clean-3.1.0.tar.gz
> 
> http://koji.fedoraproject.org/koji/buildinfo?buildID=760682

Remove opencv_xfeatures2d give us some broken deps :  

package: libfreenect-opencv-0.5.3-2.fc25.i686 from repoclosure-Everything.x86_64
  unresolved deps: 
     libopencv_xfeatures2d.so.3.1

package: os-autoinst-4.3-11.20160408gitff760a3.fc25.x86_64 from repoclosure-Everything.x86_64
  unresolved deps: 
     libopencv_xfeatures2d.so.3.1 

package: player-3.0.2-53.fc25.i686 from repoclosure-Everything.x86_64
  unresolved deps: 
     libopencv_xfeatures2d.so.3.1

package: simarrange-0.0-9.20140729git9500190.fc25.x86_64 from repoclosure-Everything.x86_64
  unresolved deps: 
     libopencv_xfeatures2d.so.3.1()(64bit)

with release 5 of opencv (opencv-3.1.0-5 ) we can build php-facedetect

Comment 66 Sergio Basto 2016-06-06 01:02:56 UTC
All broken deps solved on rawhide ! I think we may close this bug , thanks for all the help , and I hope you keep / maintain it !


Note You need to log in before you can comment on or make changes to this bug.