Bug 1238036
| Summary: | 5.3.5 : service dialog doesn't get saved in catalog items. | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Shveta <sshveta> | ||||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Dave Johnson <dajohnso> | ||||||
| Severity: | urgent | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 5.3.0 | CC: | cpelland, hkataria, jhardy, jprause, mfeifer, mpovolny, obarenbo, simaishi, sshveta | ||||||
| Target Milestone: | GA | Keywords: | ZStream | ||||||
| Target Release: | 5.3.5 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 5.3.5.3 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1238776 (view as bug list) | Environment: | |||||||
| Last Closed: | 2015-07-15 12:56:03 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1238776 | ||||||||
| Attachments: |
|
||||||||
Created attachment 1044868 [details]
ordering dialog
works with workaround. New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d4f24b5a3dab8da1404c9c9815d5a0c2f095120f commit d4f24b5a3dab8da1404c9c9815d5a0c2f095120f Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 2 11:09:24 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Jul 2 11:09:24 2015 -0400 Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=f2d466fe953fe919ace32d9cd401813560a55a60 commit f2d466fe953fe919ace32d9cd401813560a55a60 Merge: 82aa947 d4f24b5 Author: Dan Clarizio <dclarizi> AuthorDate: Thu Jul 2 11:19:45 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Thu Jul 2 11:19:45 2015 -0400 Merge branch '53z_bz_1238036' into '5.3.z' Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 @dclarizio please review. This is not a clean cherry-pick original PR: https://github.com/ManageIQ/manageiq/pull/3026 some changes cherry-picked from: https://github.com/ManageIQ/manageiq/pull/2057 to get this fix working. See merge request !151 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 commit 9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 2 11:09:24 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 7 12:12:24 2015 -0400 Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 commit b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 Merge: 619d1f8 9f230df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Jul 7 12:16:45 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Jul 7 12:16:45 2015 -0400 Merge branch '535_bz_1238036' into '5.3.5' Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) @dclarizio please review, this is a clean cherry-pick from 5.3.z commit MR for 5.3.z: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/151 See merge request !161 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 commit 9f230dfe1e6ab6d5862d45c0dfdc1e63b4fb4826 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 2 11:09:24 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Jul 7 12:12:24 2015 -0400 Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) New commit detected on cfme/5.3.5: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 commit b8e776eef548b0524f9dd5a0ce4e68fa9beecb18 Merge: 619d1f8 9f230df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Jul 7 12:16:45 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Jul 7 12:16:45 2015 -0400 Merge branch '535_bz_1238036' into '5.3.5' Made changes to make Provisioning as required entry point. - Display flash message when Display in Catalog is checked but Provisioning Entry Point is not selected, this change will allow save of Dialog for a resource action and prevent from adding a blank resource action, had to make some additional changes to code to get this working on 5.3.z - applied changes from fbc682376a86796130ad2cb4b99863e5764b9eca to 5.3.z, dialog validation is being done in controller before trying to save the catalog item. https://bugzilla.redhat.com/show_bug.cgi?id=1226428 (cherry picked from commit 4dc8d77) https://bugzilla.redhat.com/show_bug.cgi?id=1238036 (cherry picked from commit d4f24b5) @dclarizio please review, this is a clean cherry-pick from 5.3.z commit MR for 5.3.z: http://gitlab.cloudforms.lab.eng.rdu2.redhat.com/cloudforms/cfme/merge_requests/151 See merge request !161 vmdb/app/controllers/catalog_controller.rb | 28 +++++++++++++++++++--------- vmdb/app/models/service_template.rb | 9 --------- 2 files changed, 19 insertions(+), 18 deletions(-) Fixed. Verifiedin 5.3.5.3.20150708141502_b69b688 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1223.html |
Created attachment 1044867 [details] dialog not saved Description of problem: Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.create a service dialog. Create a catalog item and select the dialog 2. Save 3. catalog item shows "No dialog" 4. Order catalog item from service catalogs "Ordering dialog not available" is shown Actual results: Expected results: Additional info: 5.3.5.1.20150630091250_5515226