Bug 1238248

Summary: Review Request: perl-Term-Cap - Perl termcap interface
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Term-Cap-1.16-1.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-10 10:46:16 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2015-07-01 13:12:59 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Term-Cap/perl-Term-Cap.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Term-Cap/perl-Term-Cap-1.16-1.fc23.src.rpm
Description:
These are low-level functions to extract and use capabilities from a terminal
capability (termcap) database.

Fedora Account System Username: ppisar


This package will dual-live with perl.spec after sub-packaging there.
Comment 1 Jitka Plesnikova 2015-07-03 11:31:58 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Term-Cap-1.16-1.fc23.noarch.rpm | sort | uniq -c
      1 ncurses
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Requires perl(Carp) is missing. - Cap.pm - line 7 and 13

$ rpm -qp --provides perl-Term-Cap-1.16-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Term::Cap) = 1.16
      1 perl-Term-Cap = 1.16-1.fc23
Binary  providel are Ok.

$ rpmlint *
perl-Term-Cap.noarch: W: spelling-error Summary(en_US) termcap -> term cap, term-cap, terminate
perl-Term-Cap.noarch: W: spelling-error %description -l en_US termcap -> term cap, term-cap, terminate
perl-Term-Cap.src: W: spelling-error Summary(en_US) termcap -> term cap, term-cap, terminate
perl-Term-Cap.src: W: spelling-error %description -l en_US termcap -> term cap, term-cap, terminate
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

Please add 'perl(Carp)' to run-requires.

Otherwise package looks good.
Comment 2 Petr Pisar 2015-07-03 13:03:19 UTC 
Good catch. Updated package is on the same address.
Comment 3 Jitka Plesnikova 2015-07-03 13:07:11 UTC 
Package is good.
Approved.
Comment 4 Petr Pisar 2015-07-03 13:29:29 UTC 
New Package SCM Request
=======================
Package Name: perl-Term-Cap
Short Description: Perl termcap interface
Upstream URL: http://search.cpan.org/dist/Term-Cap/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2015-07-05 04:02:15 UTC 
Git done (by process-git-requests).
Comment 6 Petr Pisar 2015-07-10 10:46:16 UTC 
Thank you for the review and the repository.