Bug 1238248 - Review Request: perl-Term-Cap - Perl termcap interface
Summary: Review Request: perl-Term-Cap - Perl termcap interface
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-01 13:12 UTC by Petr Pisar
Modified: 2015-07-10 10:46 UTC (History)
2 users (show)

Fixed In Version: perl-Term-Cap-1.16-1.fc23
Clone Of:
Environment:
Last Closed: 2015-07-10 10:46:16 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2015-07-01 13:12:59 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Term-Cap/perl-Term-Cap.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Term-Cap/perl-Term-Cap-1.16-1.fc23.src.rpm
Description:
These are low-level functions to extract and use capabilities from a terminal
capability (termcap) database.

Fedora Account System Username: ppisar


This package will dual-live with perl.spec after sub-packaging there.

Comment 1 Jitka Plesnikova 2015-07-03 11:31:58 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Term-Cap-1.16-1.fc23.noarch.rpm | sort | uniq -c
      1 ncurses
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1

FIX: Requires perl(Carp) is missing. - Cap.pm - line 7 and 13

$ rpm -qp --provides perl-Term-Cap-1.16-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Term::Cap) = 1.16
      1 perl-Term-Cap = 1.16-1.fc23
Binary  providel are Ok.

$ rpmlint *
perl-Term-Cap.noarch: W: spelling-error Summary(en_US) termcap -> term cap, term-cap, terminate
perl-Term-Cap.noarch: W: spelling-error %description -l en_US termcap -> term cap, term-cap, terminate
perl-Term-Cap.src: W: spelling-error Summary(en_US) termcap -> term cap, term-cap, terminate
perl-Term-Cap.src: W: spelling-error %description -l en_US termcap -> term cap, term-cap, terminate
2 packages and 1 specfiles checked; 0 errors, 4 warnings.

Rpmlint is ok

Please add 'perl(Carp)' to run-requires.

Otherwise package looks good.

Comment 2 Petr Pisar 2015-07-03 13:03:19 UTC
Good catch. Updated package is on the same address.

Comment 3 Jitka Plesnikova 2015-07-03 13:07:11 UTC
Package is good.
Approved.

Comment 4 Petr Pisar 2015-07-03 13:29:29 UTC
New Package SCM Request
=======================
Package Name: perl-Term-Cap
Short Description: Perl termcap interface
Upstream URL: http://search.cpan.org/dist/Term-Cap/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2015-07-05 04:02:15 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2015-07-10 10:46:16 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.