Bug 1238269

Summary: Review Request: perl-Text-Balanced - Extract delimited text sequences from strings
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Text-Balanced-2.03-348.fc23 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-07-10 10:58:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Petr Pisar 2015-07-01 13:45:37 UTC 
Spec URL: https://ppisar.fedorapeople.org/perl-Text-Balanced/perl-Text-Balanced.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Text-Balanced/perl-Text-Balanced-2.03-1.fc23.src.rpm
Description:
These Perl subroutines may be used to extract a delimited substring, possibly
after skipping a specified prefix string.

Fedora Account System Username: ppisar


This package will dual-live with perl.spec after sub-packaging it there.
Comment 1 Jitka Plesnikova 2015-07-03 14:45:17 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Text-Balanced-2.03-1.fc23.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.005
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(SelfLoader)
      1 perl(overload)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Text-Balanced-2.03-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Text::Balanced) = 2.03
      1 perl(Text::Balanced::ErrorMsg)
      1 perl(Text::Balanced::Extractor)
      1 perl-Text-Balanced = 2.03-1.fc23
Binary provides are Ok.

$ rpmlint perl-Text-Balanced*
perl-Text-Balanced.noarch: W: spelling-error %description -l en_US substring -> sub string, sub-string, subsisting
perl-Text-Balanced.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Text-Balanced/LICENSE
perl-Text-Balanced.src: W: spelling-error %description -l en_US substring -> sub string, sub-string, subsisting
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
Rpmlint is ok. Wrong address was reported to upstream.

TODO: Build-requires perl(vars) is listed twice. Please remove one of them.

Package APPROVED.
Comment 2 Petr Pisar 2015-07-07 07:38:35 UTC 
New Package SCM Request
=======================
Package Name: perl-Text-Balanced
Short Description: Extract delimited text sequences from strings
Upstream URL: http://search.cpan.org/dist/Text-Balanced/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig
Comment 3 Gwyn Ciesla 2015-07-08 12:08:51 UTC 
Git done (by process-git-requests).
Comment 4 Petr Pisar 2015-07-10 10:58:02 UTC 
Thank you for the review and the repository.