Bug 1238269 - Review Request: perl-Text-Balanced - Extract delimited text sequences from strings
Summary: Review Request: perl-Text-Balanced - Extract delimited text sequences from st...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-01 13:45 UTC by Petr Pisar
Modified: 2015-07-10 10:58 UTC (History)
2 users (show)

Fixed In Version: perl-Text-Balanced-2.03-348.fc23
Clone Of:
Environment:
Last Closed: 2015-07-10 10:58:02 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2015-07-01 13:45:37 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Text-Balanced/perl-Text-Balanced.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Text-Balanced/perl-Text-Balanced-2.03-1.fc23.src.rpm
Description:
These Perl subroutines may be used to extract a delimited substring, possibly
after skipping a specified prefix string.

Fedora Account System Username: ppisar


This package will dual-live with perl.spec after sub-packaging it there.

Comment 1 Jitka Plesnikova 2015-07-03 14:45:17 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Text-Balanced-2.03-1.fc23.noarch.rpm | sort | uniq -c
      1 perl >= 0:5.005
      1 perl(:MODULE_COMPAT_5.22.0)
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(SelfLoader)
      1 perl(overload)
      1 perl(strict)
      1 perl(vars)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Text-Balanced-2.03-1.fc23.noarch.rpm | sort | uniq -c
      1 perl(Text::Balanced) = 2.03
      1 perl(Text::Balanced::ErrorMsg)
      1 perl(Text::Balanced::Extractor)
      1 perl-Text-Balanced = 2.03-1.fc23
Binary provides are Ok.

$ rpmlint perl-Text-Balanced*
perl-Text-Balanced.noarch: W: spelling-error %description -l en_US substring -> sub string, sub-string, subsisting
perl-Text-Balanced.noarch: E: incorrect-fsf-address /usr/share/licenses/perl-Text-Balanced/LICENSE
perl-Text-Balanced.src: W: spelling-error %description -l en_US substring -> sub string, sub-string, subsisting
2 packages and 1 specfiles checked; 1 errors, 2 warnings.
Rpmlint is ok. Wrong address was reported to upstream.

TODO: Build-requires perl(vars) is listed twice. Please remove one of them.

Package APPROVED.

Comment 2 Petr Pisar 2015-07-07 07:38:35 UTC
New Package SCM Request
=======================
Package Name: perl-Text-Balanced
Short Description: Extract delimited text sequences from strings
Upstream URL: http://search.cpan.org/dist/Text-Balanced/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-07-08 12:08:51 UTC
Git done (by process-git-requests).

Comment 4 Petr Pisar 2015-07-10 10:58:02 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.