Bug 1240502

Summary:	nfs-ganesha: remove the entry of the deleted node
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Saurabh <saujain>
Component:	gluster-nfs	Assignee:	Soumya Koduri <skoduri>
Status:	CLOSED ERRATA	QA Contact:	Matt Zywusko <mzywusko>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.1	CC:	asriram, bmohanra, byarlaga, kkeithle, mlawrenc, mzywusko, ndevos, nlevinki, rhs-bugs, sankarshan, storage-qa-internal
Target Milestone:	---	Keywords:	ZStream
Target Release:	RHGS 3.1.2
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.5-0.3	Doc Type:	Bug Fix
Doc Text:	Previously, the delete-node logic did not remove the VIP of the deleted node from ganesha-ha.conf. Due to this, the VIP existed even after the node was deleted from the HA cluster. With this fix, the delete-node operation removes the VIP associated with it from the HA cluster.	Story Points:	---
Clone Of:
Clones:	1250601 (view as bug list)		Environment:
Last Closed:	2016-03-01 05:28:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1250601
Bug Blocks:	1216951, 1256227, 1260783
Deadline:	2015-08-28

Description Saurabh 2015-07-07 06:42:05 UTC

Description of problem:
Ganesha-ha.sh script provides a functionality for deleting a nfs-ganesha node.
Post delete the ganesha-ha.conf file should have remanents of the deleted node whereas in ganesha-ha.conf file I see that it is still there, as can be seen from the example,

# Name of the HA cluster created.
# must be unique within the subnet
HA_NAME="nozomer"
#
# The gluster server from which to mount the shared data volume.
HA_VOL_SERVER="nfs11"
#
# N.B. you may use short names or long names; you may not use IP addrs.
# Once you select one, stay with it as it will be mildly unpleasant to
# clean up if you switch later on. Ensure that all names - short and/or
# long - are in DNS or /etc/hosts on all machines in the cluster.
#
# The subset of nodes of the Gluster Trusted Pool that form the ganesha
# HA cluster. Hostname is specified.
HA_CLUSTER_NODES="nfs11,nfs12,nfs13,nfs14"
#HA_CLUSTER_NODES="nfs11,nfs12,nfs13,nfs14,nfs16"
#
# Virtual IPs for each of the nodes specified above.
VIP_nfs11="10.70.44.92"
VIP_nfs12="10.70.44.93"
VIP_nfs13="10.70.44.94"
VIP_nfs14="10.70.44.95"
#VIP_server1.lab.redhat.com="10.0.2.1"
#VIP_server2.lab.redhat.com="10.0.2.2"
VIP_nfs16="10.70.44.96"

As can be seen that last VIP_nfs16 is still there and it should be deleted

Version-Release number of selected component (if applicable):
nfs-ganesha-2.2.0-3.el6rhs.x86_64

How reproducible:
always

Actual results:
as described above

Expected results:
remove all the entries related of the deleted node from the configuration files

Additional info:

Comment 2 Kaleb KEITHLEY 2015-07-07 10:35:17 UTC

Leaving VIP_$host for a deleted host in the ganesha-ha.conf is benign.

A system admin can edit the file and delete it if it's bothersome.

It's possible that repeated add+delete could get confused, but not a normal thing.

I don't see this as a blocker.

Comment 3 monti lawrence 2015-07-22 21:09:29 UTC

Doc text is edited. Please sign off to be included in Known Issues.

Comment 4 Meghana 2015-07-27 09:26:40 UTC

Doc text looks good to me.

Comment 5 Kaleb KEITHLEY 2015-08-04 10:34:27 UTC

stretch goal for 3.1.1

Comment 7 Niels de Vos 2015-10-09 10:01:23 UTC

Needs a backport of bug 1250601

Comment 9 Saurabh 2015-10-26 08:04:34 UTC

verified on glusterfs-3.7.5-0.3.el7rhgs.x86_64 and nfs-ganesha-2.2.0-10.el7rhgs.x86_64.

Comment 13 errata-xmlrpc 2016-03-01 05:28:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0193.html