Bug 1240991

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#10) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#11) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#14) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#15) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#16) for review on master by Vijaikumar Mallikarjuna (vmallika)

REVIEW: http://review.gluster.org/11578 (quota/marker: fix inode quota with rename) posted (#17) for review on master by Vijaikumar Mallikarjuna (vmallika)

COMMIT: http://review.gluster.org/11578 committed in master by Raghavendra G (rgowdapp) 
------
commit 4efc8ea17f8452cf5a5f3a504419c1269d332d79
Author: vmallika <vmallika>
Date:   Sun Jul 12 08:49:49 2015 +0530

    quota/marker: fix inode quota with rename
    
    There are three problems with marker-rename which
    is fixed in this patch
    
    Problem 1)
    1) mq_reduce_parent_size is not handling inode-quota contribution
    2) When dest files exists and IO is happening
       Now renaming will overwrite existing file
       mq_reduce_parent_size called on dest file
       with saved contribution, this can be
       a problem is IO is still happening
       contribution might have changed
    
    Problem 2)
    There is a small race between rename and in-progress write
    Consider below scenario
    1) rename FOP invoked on file 'x'
    2) write is still in progress for file 'x'
    3) rename takes a lock on old-parent
    4) write-update txn blocked on old-parent to acquire lock
    5) in rename_cbk, contri xattrs are removed and contribution is deleted and
       lock is released
    6) now write-update txn gets the lock and updates the wrong parent
       as it was holding lock on old parent
       so validate parent once the lock is acquired
    
    Problem 3)
    when a rename operation is performed, a lock is
    held on old parent. This lock is release before
    unwinding the rename operation.
    This can be a problem if there are in-progress
    writes happening during rename, where update txn
    can take a lock and update the old parent
    as inode table is not updated with new parent
    
    Change-Id: Ic3316097c001c33533f98592e8fcf234b1ee2aa2
    BUG: 1240991
    Signed-off-by: vmallika <vmallika>
    Reviewed-on: http://review.gluster.org/11578
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>
    Reviewed-by: Raghavendra G <rgowdapp>

Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well.

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user