Bug 1241671

Summary: python-requests: missing provides for python2-requests
Product: [Fedora] Fedora Reporter: Carl George <carl>
Component: python-requestsAssignee: Arun S A G <sagarun>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 22CC: plautrba, rbean, sagarun
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-requests-2.7.0-5.fc23 python-requests-2.7.0-5.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-10-03 17:55:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Carl George 2015-07-09 18:47:20 UTC
Description of problem:
Per the Python Packaging guidelines [1], python-requests should provide python2-requests.

Actual results:
python-requests does not provide python2-requests

Expected results:
python-requests should provide python2-requests

Additional info:
[1]: http://fedoraproject.org/wiki/Packaging:Python#Provides

Comment 1 Fedora Update System 2015-09-15 21:16:58 UTC
python-requests-2.7.0-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15949

Comment 2 Fedora Update System 2015-09-15 21:19:43 UTC
python-requests-2.7.0-4.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-15950

Comment 3 Fedora Update System 2015-09-16 04:52:37 UTC
python-requests-2.7.0-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-requests'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15949

Comment 4 Fedora Update System 2015-09-17 01:05:43 UTC
python-requests-2.7.0-4.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-requests'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-15950

Comment 5 Carl George 2015-09-17 13:45:31 UTC
I don't believe this was correctly fixed.  Neither package provides 'python2-requests', and the python3-requests package is providing 'python-requests' (it shouldn't do that until python3 becomes the default system runtime).

> $ rpm -qp --provides python-requests-2.7.0-4.fc22.noarch.rpm 
> python-requests = 2.7.0-4.fc22

> $ rpm -qp --provides python3-requests-2.7.0-4.fc22.noarch.rpm 
> python-requests = 2.7.0-4.fc22
> python3-requests = 2.7.0-4.fc22

I think this is because the python_provide macro wasn't used as intended.  According to the example in the wiki [1], I think that macro expects the package layout to have two subpackages, one for python2 and one for python3.

> Name:           python-%{srcname}
> 
> %package -n python2-%{srcname}
> %{?python_provide:%python_provide python2-%{srcname}}
> 
> %package -n python3-%{srcname}
> %{?python_provide:%python_provide python3-%{srcname}}

The guidelines [2] even explictily state that the macro is intended to be used from within a subpackage.

> When given (as an argument) the name of the current subpackage, it will
> evaluate to either the proper Provide: line or nothing at all as appropriate
> for the version of the system runtime. Thus if the package follows the
> suggested subpackage naming scheme as shown in the below example, placing
> this macro in the definition of each subpackage will guarantee that the
> necessary Provide: line appears where it should, and does not appear where
> it shouldn't.

[1]: http://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
[2]: http://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macro

Comment 6 Fedora Update System 2015-09-17 13:54:10 UTC
python-requests-2.7.0-5.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16096

Comment 7 Fedora Update System 2015-09-17 14:27:29 UTC
python-requests-2.7.0-5.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-16097

Comment 8 Fedora Update System 2015-09-17 21:29:39 UTC
python-requests-2.7.0-5.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-requests'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16096

Comment 9 Fedora Update System 2015-09-18 16:24:18 UTC
python-requests-2.7.0-5.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.\nIf you want to test the update, you can install it with \n su -c 'yum --enablerepo=updates-testing update python-requests'. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-16097

Comment 10 Fedora Update System 2015-10-03 17:55:46 UTC
python-requests-2.7.0-5.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2015-10-03 21:17:02 UTC
python-requests-2.7.0-5.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.

Comment 12 Jakub Kadlčík 2015-10-14 10:15:09 UTC
*** Bug 1264426 has been marked as a duplicate of this bug. ***