Bug 1242022

Summary: rdma : pending - porting log messages to a new framework
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: SATHEESARAN <sasundar>
Component: coreAssignee: Manikandan <mselvaga>
Status: CLOSED ERRATA QA Contact: SATHEESARAN <sasundar>
Severity: high Docs Contact:
Priority: unspecified    
Version: rhgs-3.1CC: byarlaga, mselvaga, rhs-bugs, sankarshan, smohan, storage-qa-internal
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.1.2   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.5-0.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1242333 1252272 (view as bug list) Environment:
Last Closed: 2016-03-01 05:29:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1241957, 1242333, 1252272, 1252274, 1260783    

Description SATHEESARAN 2015-07-10 16:55:32 UTC
Description of problem:
-----------------------
There are occurrences of gf_log and gf_log_callingfn under posix.
These instances should be ported to the corresponding gf_msg functions

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS 3.1 Nightly ( glusterfs-3.7.1-8.el6rhs )

Info:
-----
gf_log instances
=================
[satheesaran@dhcppc1 rdma]$ grep -r "gf_log " * -A1
src/name.c:  gf_log (this->name, GF_LOG_DEBUG,
src/name.c-    "transport.rdma.bind-path not specified "
--
src/name.c:  gf_log (this->name, GF_LOG_ERROR,
src/name.c-    "cannot bind to unix-domain socket %d (%s)",
--
src/rdma.c:  gf_log ("rdma", GF_LOG_WARNING,
src/rdma.c-     "deallocation of memory region "

gf_log_callingfn instances
===========================
[satheesaran@dhcppc1 rdma]$ grep -r "gf_log_callingfn " * -A1
src/rdma.c:    gf_log_callingfn (GF_RDMA_LOG_NAME, GF_LOG_WARNING,
src/rdma.c-       "not able to get a post to send msg");
--
src/rdma.c:    gf_log_callingfn (this->name, GF_LOG_DEBUG,
src/rdma.c-        "disconnect called (peer:%s)",

Comment 1 Manikandan 2015-07-13 06:39:24 UTC
Patch posted upstream master
http://review.gluster.org/#/c/11607/

Comment 2 Manikandan 2015-07-30 10:56:19 UTC
Patch is merged.

Comment 5 Manikandan 2015-08-11 06:35:23 UTC
*** Bug 1252274 has been marked as a duplicate of this bug. ***

Comment 6 Manikandan 2015-08-11 07:09:18 UTC
Hi Vivek,
I have posted the patch to release-3.7 branch.

http://review.gluster.org/#/c/11878/ (Release - 3.7)

https://code.engineering.redhat.com/gerrit/#/c/54855/ (Downstream)

Comment 7 Vivek Agarwal 2015-08-11 07:15:11 UTC
Thanks Manikandan.

Comment 10 Manikandan 2015-10-16 06:31:11 UTC
Patch upstream : http://review.gluster.org/#/c/11607/
Patch release-3.7 :http://review.gluster.org/11878

Comment 11 SATHEESARAN 2015-10-26 09:39:22 UTC
Verified with the latest code as available under RHGS 3.1.2 downstream branch.

There were no instances of gf_log or gf_log_callingfn

Marking this bug as VERIFIED

Comment 13 errata-xmlrpc 2016-03-01 05:29:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-0193.html