Bug 1242333

Summary:	rdma : pending - porting log messages to a new framework
Product:	[Community] GlusterFS	Reporter:	Manikandan <mselvaga>
Component:	logging	Assignee:	Manikandan <mselvaga>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	annair, bugs, rhs-bugs, sasundar, smohan
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.8rc2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1242022	Environment:
Last Closed:	2016-06-16 13:22:53 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1242022, 1252272, 1252274
Bug Blocks:	1241957

Description Manikandan 2015-07-13 06:28:51 UTC

+++ This bug was initially created as a clone of Bug #1242022 +++

Description of problem:
-----------------------
There are occurrences of gf_log and gf_log_callingfn under posix.
These instances should be ported to the corresponding gf_msg functions

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
RHGS 3.1 Nightly ( glusterfs-3.7.1-8.el6rhs )

Info:
-----
gf_log instances
=================
[satheesaran@dhcppc1 rdma]$ grep -r "gf_log " * -A1
src/name.c:  gf_log (this->name, GF_LOG_DEBUG,
src/name.c-    "transport.rdma.bind-path not specified "
--
src/name.c:  gf_log (this->name, GF_LOG_ERROR,
src/name.c-    "cannot bind to unix-domain socket %d (%s)",
--
src/rdma.c:  gf_log ("rdma", GF_LOG_WARNING,
src/rdma.c-     "deallocation of memory region "

gf_log_callingfn instances
===========================
[satheesaran@dhcppc1 rdma]$ grep -r "gf_log_callingfn " * -A1
src/rdma.c:    gf_log_callingfn (GF_RDMA_LOG_NAME, GF_LOG_WARNING,
src/rdma.c-       "not able to get a post to send msg");
--
src/rdma.c:    gf_log_callingfn (this->name, GF_LOG_DEBUG,
src/rdma.c-        "disconnect called (peer:%s)",

Comment 1 Anand Avati 2015-07-13 06:30:51 UTC

REVIEW: http://review.gluster.org/11607 (rdma : porting missing gf_log to gf_msg) posted (#3) for review on master by Manikandan Selvaganesh (mselvaga)

Comment 2 Manikandan 2015-07-13 06:38:48 UTC

Patch posted upstream master
http://review.gluster.org/#/c/11607/

Comment 3 Anand Avati 2015-07-13 06:50:04 UTC

COMMIT: http://review.gluster.org/11607 committed in master by Raghavendra G (rgowdapp) 
------
commit 6beb9ca292a0653d3d082af9d30f519a99569a14
Author: Manikandan Selvaganesh <mselvaga>
Date:   Fri Jul 10 10:50:40 2015 +0530

    rdma : porting missing gf_log to gf_msg
    
    Change-Id: I036b43007fbcd0e528faab8d44e1a7fc820eaf1f
    BUG: 1242333
    Signed-off-by: Manikandan Selvaganesh <mselvaga>
    Reviewed-on: http://review.gluster.org/11607
    Reviewed-by: Raghavendra G <rgowdapp>
    Tested-by: Raghavendra G <rgowdapp>

Comment 4 Niels de Vos 2016-06-16 13:22:53 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user