Bug 1242536

+++ This bug was initially created as a clone of Bug #1241054 +++

nchilaka 2015-07-01 07:33:53 EDT

Description of problem:
=========================
When you rename a cold file, the file should get heated up and eventually move to hot tier. But that is not happening.
This is a case of metadata change which means ideally it should increase the counter of file to get heated up, but is not happening

Version-Release number of selected component (if applicable):
============================================================
[root@tettnang ~]# gluster --version
glusterfs 3.7.1 built on Jun 28 2015 11:01:14
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General Public License.
[root@tettnang ~]# rpm -qa|grep gluster
glusterfs-cli-3.7.1-6.el7rhgs.x86_64
glusterfs-client-xlators-3.7.1-6.el7rhgs.x86_64
glusterfs-fuse-3.7.1-6.el7rhgs.x86_64
glusterfs-geo-replication-3.7.1-6.el7rhgs.x86_64
glusterfs-libs-3.7.1-6.el7rhgs.x86_64
glusterfs-api-3.7.1-6.el7rhgs.x86_64
glusterfs-rdma-3.7.1-6.el7rhgs.x86_64
glusterfs-3.7.1-6.el7rhgs.x86_64
glusterfs-debuginfo-3.7.1-6.el7rhgs.x86_64
glusterfs-server-3.7.1-6.el7rhgs.x86_64
[root@tettnang ~]# 




Steps to Reproduce:
===================
1.create a regular volume and start it.
2.set following options
 performance.quick-read: off
performance.io-cache: off

3.Now attach a tier and enable features.ctr-enabled.
4. fuse mount the volume
5. Create a file and check if it is created in hot tier(works as expected)
6.  Now wait for say about 3min by keeping the setup idle.
7. Now the file should have been moved to cold tier(works as expected)
8.Now do a rename of the file

Actual results:
===============
rename passes, but the file doesnt get heated,even though the ctime changes, which is a metadata change action

Note:
I haven't set promote/demote freq. Which means the default time should be about 120sec
Also, I haven't turned on  features.record-counters or read/write threshold counters, which means I file should get heated if modified even once.


Logs will be attached



Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-07-08 11:57:53 EDT ---

REVIEW: http://review.gluster.org/11584 (libgfdb/ctr: Fixing rename or update of link) posted (#1) for review on master by Joseph Fernandes

--- Additional comment from Joseph Elwin Fernandes on 2015-07-08 12:51:45 EDT ---

Tested by abusing rename :) 

for i in {1..100000}; do mv file file1 ; mv file1 file;  done

--- Additional comment from Anand Avati on 2015-07-09 15:11:34 EDT ---

COMMIT: http://review.gluster.org/11584 committed in master by Dan Lambright (dlambrig) 
------
commit 3c25f33162c981d18bf78d1fc3536496670959e9
Author: Joseph Fernandes <josferna>
Date:   Wed Jul 8 21:22:53 2015 +0530

    libgfdb/ctr: Fixing rename or update of link
    
    Fixing rename or updating of link in
    1) libgfdb : handling return from updatelink
    2) ctr xlator: correcting freeing of oldbase name in
                   hardlink list in the update link
    
    Change-Id: I1789c492b81876123cd456051a9ae495e876ad46
    BUG: 1241054
    Signed-off-by: Joseph Fernandes <josferna>
    Reviewed-on: http://review.gluster.org/11584
    Tested-by: Joseph Fernandes
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Dan Lambright <dlambrig>
    Tested-by: Gluster Build System <jenkins.com>