Bug 1243642

Summary:	GF_CONTENT_KEY should not be handled unless we are sure no other operations are in progress
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	3.7.3	CC:	bugs, gluster-bugs, ravishankar
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.3	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1226279	Environment:
Last Closed:	2015-07-30 09:47:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1226279
Bug Blocks:

Description Pranith Kumar K 2015-07-16 02:37:53 UTC

+++ This bug was initially created as a clone of Bug #1226279 +++

Description of problem:
GF_CONTENT_KEY aggregation requires that the fragments on the bricks belong to same data i.e. no operations are modifying the content while lookup is performed on it. The only way to know it is to get at least ec->fragments+1 number of responses and see that two different sets of ec->fragments number of fragments give same data. But at the moment we feel that this slows down ec-lookup. So removing handling of this for now.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-05-29 07:21:31 EDT ---

REVIEW: http://review.gluster.org/11003 (cluster/ec: Do not handle GF_CONTENT_KEY) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-06-03 22:46:15 EDT ---

REVIEW: http://review.gluster.org/11003 (cluster/ec: Do not handle GF_CONTENT_KEY) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-06-23 05:13:43 EDT ---

COMMIT: http://review.gluster.org/11003 committed in master by Xavier Hernandez (xhernandez) 
------
commit 653d3c1406e372aabcf694bfead2d695f84ee0f8
Author: Pranith Kumar K <pkarampu>
Date:   Thu May 28 15:33:18 2015 +0530

    cluster/ec: Do not handle GF_CONTENT_KEY
    
    GF_CONTENT_KEY aggregation requires that the fragments on the bricks belong to
    same data i.e. no operations are modifying the content while lookup is
    performed on it. The only way to know it is to get at least ec->fragments+1
    number of responses and see that two different sets of ec->fragments number of
    fragments give same data. But at the moment we feel that this slows down
    ec-lookup. So removing handling of this for now.
    
    Change-Id: I2da5087f1311d5cdde999062607b143b48c17713
    BUG: 1226279
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/11003
    Reviewed-by: Xavier Hernandez <xhernandez>
    Tested-by: Gluster Build System <jenkins.com>
    Tested-by: NetBSD Build System <jenkins.org>

Comment 1 Anand Avati 2015-07-21 09:32:29 UTC

REVIEW: http://review.gluster.org/11678 (cluster/ec: Do not handle GF_CONTENT_KEY) posted (#2) for review on release-3.7 by Xavier Hernandez (xhernandez)

Comment 2 Ravishankar N 2015-07-21 12:19:58 UTC

Triaged as a part of weekly meeting. Moving the bug to MODIFIED since the patch seems to be merged.

Comment 3 Kaushal 2015-07-30 09:47:41 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report.

glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user