Bug 1243872

Summary: SCVMM: "[RuntimeError]: Host not specified, unable to migrate VM Method:[rescue in execute]" on VM migrate
Product: Red Hat CloudForms Management Engine Reporter: Harpreet Kataria <hkataria>
Component: UI - OPSAssignee: Harpreet Kataria <hkataria>
Status: CLOSED ERRATA QA Contact: Jeff Teehan <jteehan>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.4.0CC: akarol, cpelland, dajohnso, hkataria, jhardy, jprause, jteehan, mfeifer, mpovolny, obarenbo, tcarlin
Target Milestone: GAKeywords: ZStream
Target Release: 5.4.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.4.3.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1221532 Environment:
Last Closed: 2015-10-22 14:32:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1221532    
Bug Blocks:    

Comment 2 CFME Bot 2015-07-23 15:32:28 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d546ed7b4bc8a3276360064d182d08a69a62f4e7

commit d546ed7b4bc8a3276360064d182d08a69a62f4e7
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Jul 16 10:13:27 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Jul 16 13:50:16 2015 -0400

    Remove Migrate button for SCVMM VMs
    
    - Added new model methods, changed code to use is_available? method to determine availability of "migrate" task for VMs similar to power buttons for VMs
    - Added "validate_migrate" method to VM subclasses and have it return false for Redhat & SCVMM VMs, to hide Migrate button on appropriate VM summary screens.
    - Added "batch_operation_supported?" method to determine if any of the selected VMs are not allowed to perform migrate task.
    - Added spec tests around new methods.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872

 vmdb/app/controllers/application_controller.rb     | 30 ++++++++++++++-----
 vmdb/app/helpers/application_helper.rb             |  4 ++-
 vmdb/app/models/vm.rb                              |  3 ++
 vmdb/app/models/vm_amazon.rb                       |  4 +++
 vmdb/app/models/vm_microsoft.rb                    |  4 +++
 vmdb/app/models/vm_openstack.rb                    |  4 +++
 vmdb/app/models/vm_or_template.rb                  |  8 +++++
 vmdb/app/models/vm_redhat.rb                       |  4 +++
 vmdb/app/models/vm_vmware.rb                       |  4 +++
 vmdb/app/models/vm_xen.rb                          |  3 ++
 .../controllers/application_controller_spec.rb     | 34 ++++++++++++++++++++++
 vmdb/spec/helpers/application_helper_spec.rb       | 31 ++++++++++++++++++--
 vmdb/spec/models/vm_or_template_spec.rb            | 26 +++++++++++++++++
 13 files changed, 147 insertions(+), 12 deletions(-)

Comment 3 CFME Bot 2015-07-23 15:32:41 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=263fc0366a35b74ce93569d1a032527c0c3e08e9

commit 263fc0366a35b74ce93569d1a032527c0c3e08e9
Merge: 577bad3 d546ed7
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Jul 23 11:27:25 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Jul 23 11:27:25 2015 -0400

    Merge branch '54z_bz_1243872' into '5.4.z'
    
    Remove Migrate button for SCVMM VMs
    
    - Added new model methods, changed code to use is_available? method to determine availability of "migrate" task for VMs similar to power buttons for VMs
    - Added "validate_migrate" method to VM subclasses and have it return false for Redhat & SCVMM VMs, to hide Migrate button on appropriate VM summary screens.
    - Added "batch_operation_supported?" method to determine if any of the selected VMs are not allowed to perform migrate task.
    - Added spec tests around new methods.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872
    
    @dclarizio please review, had to merge some conflicts manually after applying changes from the patch toolbar code has been moved out of application_helper on upstream codebase, original PR: https://github.com/ManageIQ/manageiq/pull/2928
    
    See merge request !184

 vmdb/app/controllers/application_controller.rb     | 30 ++++++++++++++-----
 vmdb/app/helpers/application_helper.rb             |  4 ++-
 vmdb/app/models/vm.rb                              |  3 ++
 vmdb/app/models/vm_amazon.rb                       |  4 +++
 vmdb/app/models/vm_microsoft.rb                    |  4 +++
 vmdb/app/models/vm_openstack.rb                    |  4 +++
 vmdb/app/models/vm_or_template.rb                  |  8 +++++
 vmdb/app/models/vm_redhat.rb                       |  4 +++
 vmdb/app/models/vm_vmware.rb                       |  4 +++
 vmdb/app/models/vm_xen.rb                          |  3 ++
 .../controllers/application_controller_spec.rb     | 34 ++++++++++++++++++++++
 vmdb/spec/helpers/application_helper_spec.rb       | 31 ++++++++++++++++++--
 vmdb/spec/models/vm_or_template_spec.rb            | 26 +++++++++++++++++
 13 files changed, 147 insertions(+), 12 deletions(-)

Comment 5 Thom Carlin 2015-08-26 15:00:51 UTC
After step 2, I get "Migrate does not apply to selected VM Template" (even for VM's).

Comment 8 CFME Bot 2015-08-27 21:18:51 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/808f5b661a0f60c45ab1ba1d5e212d045eb0695a

commit 808f5b661a0f60c45ab1ba1d5e212d045eb0695a
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Aug 27 12:05:47 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Aug 27 14:57:59 2015 -0400

    Fixed flash message to be more generic.
    
    Fixed existing spec test to check for updated flash message.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872

 app/controllers/application_controller.rb       | 8 +++++---
 spec/controllers/application_controller_spec.rb | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment 10 CFME Bot 2015-08-28 15:13:05 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c6277a441b89e6dd7321344e9b20c6b3d498d217

commit c6277a441b89e6dd7321344e9b20c6b3d498d217
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Aug 27 17:32:25 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Aug 27 17:32:25 2015 -0400

    Fixed flash message to be more generic.
    
    Fixed existing spec test to check for updated flash message.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872

 vmdb/app/controllers/application_controller.rb       | 8 +++++---
 vmdb/spec/controllers/application_controller_spec.rb | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment 11 CFME Bot 2015-08-28 15:13:12 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=3783724bf2e97bd545537858ab7e8b009202a412

commit 3783724bf2e97bd545537858ab7e8b009202a412
Merge: 1196c64 c6277a4
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Aug 28 11:02:23 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri Aug 28 11:02:23 2015 -0400

    Merge branch '54z_bz_1243872' into '5.4.z'
    
    Fixed flash message to be more generic.
    
    Fixed existing spec test to check for updated flash message.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872
    
    @dclarizio please review, clean path was applied
    original PR: https://github.com/ManageIQ/manageiq/pull/4079
    
    See merge request !240

 vmdb/app/controllers/application_controller.rb       | 8 +++++---
 vmdb/spec/controllers/application_controller_spec.rb | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment 12 CFME Bot 2015-08-28 15:19:09 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c6277a441b89e6dd7321344e9b20c6b3d498d217

commit c6277a441b89e6dd7321344e9b20c6b3d498d217
Author:     Harpreet Kataria <hkataria>
AuthorDate: Thu Aug 27 17:32:25 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Thu Aug 27 17:32:25 2015 -0400

    Fixed flash message to be more generic.
    
    Fixed existing spec test to check for updated flash message.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872

 vmdb/app/controllers/application_controller.rb       | 8 +++++---
 vmdb/spec/controllers/application_controller_spec.rb | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment 13 CFME Bot 2015-08-28 15:19:15 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=3783724bf2e97bd545537858ab7e8b009202a412

commit 3783724bf2e97bd545537858ab7e8b009202a412
Merge: 1196c64 c6277a4
Author:     Dan Clarizio <dclarizi>
AuthorDate: Fri Aug 28 11:02:23 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Fri Aug 28 11:02:23 2015 -0400

    Merge branch '54z_bz_1243872' into '5.4.z'
    
    Fixed flash message to be more generic.
    
    Fixed existing spec test to check for updated flash message.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1221532
    https://bugzilla.redhat.com/show_bug.cgi?id=1243872
    
    @dclarizio please review, clean path was applied
    original PR: https://github.com/ManageIQ/manageiq/pull/4079
    
    See merge request !240

 vmdb/app/controllers/application_controller.rb       | 8 +++++---
 vmdb/spec/controllers/application_controller_spec.rb | 2 +-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comment 15 Jeff Teehan 2015-10-12 15:46:30 UTC
Using https://10.8.59.221/vm_infra/explorer

Verified that the screen matches the expected screenshot on github issue.  Moving to verified.

Comment 17 errata-xmlrpc 2015-10-22 14:32:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1916.html