Description of problem: Version-Release number of selected component (if applicable): 5.4.0.0.23.20150423131011_69b48fd How reproducible: 100% Steps to Reproduce: 1.Navigate to infrastructure->providers->add scvmm provider 2.select a VM and from lifecycle->Migrate this VM 3.Fill the request information and click on submit .(Do not fill Environment info) Actual results: Request get submitted. Expected results: valid flash message should be required if no host specified Additional info: evm.log: [----] I, [2015-05-14T05:26:21.432733 #2328:104dea8] INFO -- : Q-task_id([vm_migrate_task_3]) MIQ(VmMigrateTask.execute) Executing VM Migrate request: [VM Migrate for: test_scvmm - ] [----] I, [2015-05-14T05:26:21.452732 #2328:104dea8] INFO -- : Q-task_id([vm_migrate_task_3]) MIQ(VmMigrateTask.execute) VM Migrate initiated [----] W, [2015-05-14T05:26:21.493898 #2328:104dea8] WARN -- : Q-task_id([vm_migrate_task_3]) MIQ(VmMigrateTask.do_request) Calling VM migrate for 15:test_scvmm [----] E, [2015-05-14T05:26:21.495984 #2328:104dea8] ERROR -- : Q-task_id([vm_migrate_task_3]) MIQ(VmMigrateTask.execute) [Error: Host not specified, unable to migrate VM] encountered during VM Migrate [----] E, [2015-05-14T05:26:21.496222 #2328:104dea8] ERROR -- : Q-task_id([vm_migrate_task_3]) [RuntimeError]: Host not specified, unable to migrate VM Method:[rescue in execute] [----] E, [2015-05-14T05:26:21.496412 #2328:104dea8] ERROR -- : Q-task_id([vm_migrate_task_3]) /var/www/miq/vmdb/app/models/vm_or_template/operations/relocation.rb:4:in `raw_migrate' /var/www/miq/vmdb/app/models/vm_or_template/operations/relocation.rb:19:in `migrate' /var/www/miq/vmdb/app/models/vm_migrate_task.rb:71:in `do_request' /var/www/miq/vmdb/app/models/miq_request_task.rb:191:in `execute' /var/www/miq/vmdb/app/models/miq_queue.rb:356:in `block in deliver' /opt/rh/ruby200/root/usr/share/ruby/timeout.rb:66:in `timeout' /var/www/miq/vmdb/app/models/miq_queue.rb:352:in `deliver' /var/www/miq/vmdb/lib/workers/queue_worker_base.rb:107:in `deliver_queue_message' /var/www/miq/vmdb/lib/workers/queue_worker_base.rb:135:in `deliver_message' /var/www/miq/vmdb/lib/workers/queue_worker_base.rb:152:in `block in do_work' /var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `loop' /var/www/miq/vmdb/lib/workers/queue_worker_base.rb:146:in `do_work' /var/www/miq/vmdb/lib/workers/worker_base.rb:323:in `block in do_work_loop' /var/www/miq/vmdb/lib/workers/worker_base.rb:320:in `loop' /var/www/miq/vmdb/lib/workers/worker_base.rb:320:in `do_work_loop' /var/www/miq/vmdb/lib/workers/worker_base.rb:141:in `run' /var/www/miq/vmdb/lib/workers/worker_base.rb:122:in `start' /var/www/miq/vmdb/lib/workers/worker_base.rb:23:in `start_worker' /var/www/miq/vmdb/lib/workers/bin/worker.rb:3:in `<top (required)>' /opt/rh/cfme-gemset/bundler/gems/rails-4842a8377644/railties/lib/rails/commands/runner.rb:52:in `eval' /opt/rh/cfme-gemset/bundler/gems/rails-4842a8377644/railties/lib/rails/commands/runner.rb:52:in `<top (required)>' /opt/rh/cfme-gemset/bundler/gems/rails-4842a8377644/railties/lib/rails/commands.rb:64:in `require' /opt/rh/cfme-gemset/bundler/gems/rails-4842a8377644/railties/lib/rails/commands.rb:64:in `<top (required)>' script/rails:6:in `require' script/rails:6:in `<main>'
Ultimately this is a 'remove the option' until we have this in place. Perhaps we need to add a RFE as well but I think that will happen on its own.
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/283fe0819e67fbe6e48aee2df0980d4c40774b16 commit 283fe0819e67fbe6e48aee2df0980d4c40774b16 Author: Harpreet Kataria <hkataria> AuthorDate: Fri May 15 10:28:56 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jul 15 23:06:26 2015 -0400 Remove Migrate button for SCVMM VMs - Added new model methods, changed code to use is_available? method to determine availability of "migrate" task for VMs similar to power buttons for VMs - Added "validate_migrate" method to VM subclasses and have it return false for Redhat & SCVMM VMs, to hide Migrate button on appropriate VM summary screens. - Added "batch_operation_supported?" method to determine if any of the selected VMs are not allowed to perform migrate task. - Added spec tests around new methods. https://bugzilla.redhat.com/show_bug.cgi?id=1221532 app/controllers/application_controller.rb | 30 ++++++++++++++----- app/helpers/application_helper/toolbar_builder.rb | 4 ++- .../manageiq/providers/amazon/cloud_manager/vm.rb | 4 +++ .../manageiq/providers/redhat/infra_manager/vm.rb | 4 +++ .../manageiq/providers/vmware/infra_manager/vm.rb | 4 +++ app/models/vm_microsoft.rb | 4 +++ app/models/vm_openstack.rb | 4 +++ app/models/vm_or_template.rb | 8 +++++ app/models/vm_xen.rb | 3 ++ spec/controllers/application_controller_spec.rb | 34 ++++++++++++++++++++++ .../application_helper/toolbar_builder_spec.rb | 5 ++-- spec/models/vm_or_template_spec.rb | 26 +++++++++++++++++ 12 files changed, 118 insertions(+), 12 deletions(-)
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=d546ed7b4bc8a3276360064d182d08a69a62f4e7 commit d546ed7b4bc8a3276360064d182d08a69a62f4e7 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Jul 16 10:13:27 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Jul 16 13:50:16 2015 -0400 Remove Migrate button for SCVMM VMs - Added new model methods, changed code to use is_available? method to determine availability of "migrate" task for VMs similar to power buttons for VMs - Added "validate_migrate" method to VM subclasses and have it return false for Redhat & SCVMM VMs, to hide Migrate button on appropriate VM summary screens. - Added "batch_operation_supported?" method to determine if any of the selected VMs are not allowed to perform migrate task. - Added spec tests around new methods. https://bugzilla.redhat.com/show_bug.cgi?id=1221532 https://bugzilla.redhat.com/show_bug.cgi?id=1243872 vmdb/app/controllers/application_controller.rb | 30 ++++++++++++++----- vmdb/app/helpers/application_helper.rb | 4 ++- vmdb/app/models/vm.rb | 3 ++ vmdb/app/models/vm_amazon.rb | 4 +++ vmdb/app/models/vm_microsoft.rb | 4 +++ vmdb/app/models/vm_openstack.rb | 4 +++ vmdb/app/models/vm_or_template.rb | 8 +++++ vmdb/app/models/vm_redhat.rb | 4 +++ vmdb/app/models/vm_vmware.rb | 4 +++ vmdb/app/models/vm_xen.rb | 3 ++ .../controllers/application_controller_spec.rb | 34 ++++++++++++++++++++++ vmdb/spec/helpers/application_helper_spec.rb | 31 ++++++++++++++++++-- vmdb/spec/models/vm_or_template_spec.rb | 26 +++++++++++++++++ 13 files changed, 147 insertions(+), 12 deletions(-)
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=263fc0366a35b74ce93569d1a032527c0c3e08e9 commit 263fc0366a35b74ce93569d1a032527c0c3e08e9 Merge: 577bad3 d546ed7 Author: Dan Clarizio <dclarizi> AuthorDate: Thu Jul 23 11:27:25 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Thu Jul 23 11:27:25 2015 -0400 Merge branch '54z_bz_1243872' into '5.4.z' Remove Migrate button for SCVMM VMs - Added new model methods, changed code to use is_available? method to determine availability of "migrate" task for VMs similar to power buttons for VMs - Added "validate_migrate" method to VM subclasses and have it return false for Redhat & SCVMM VMs, to hide Migrate button on appropriate VM summary screens. - Added "batch_operation_supported?" method to determine if any of the selected VMs are not allowed to perform migrate task. - Added spec tests around new methods. https://bugzilla.redhat.com/show_bug.cgi?id=1221532 https://bugzilla.redhat.com/show_bug.cgi?id=1243872 @dclarizio please review, had to merge some conflicts manually after applying changes from the patch toolbar code has been moved out of application_helper on upstream codebase, original PR: https://github.com/ManageIQ/manageiq/pull/2928 See merge request !184 vmdb/app/controllers/application_controller.rb | 30 ++++++++++++++----- vmdb/app/helpers/application_helper.rb | 4 ++- vmdb/app/models/vm.rb | 3 ++ vmdb/app/models/vm_amazon.rb | 4 +++ vmdb/app/models/vm_microsoft.rb | 4 +++ vmdb/app/models/vm_openstack.rb | 4 +++ vmdb/app/models/vm_or_template.rb | 8 +++++ vmdb/app/models/vm_redhat.rb | 4 +++ vmdb/app/models/vm_vmware.rb | 4 +++ vmdb/app/models/vm_xen.rb | 3 ++ .../controllers/application_controller_spec.rb | 34 ++++++++++++++++++++++ vmdb/spec/helpers/application_helper_spec.rb | 31 ++++++++++++++++++-- vmdb/spec/models/vm_or_template_spec.rb | 26 +++++++++++++++++ 13 files changed, 147 insertions(+), 12 deletions(-)
https://github.com/ManageIQ/manageiq/pull/4079
Detected commit referencing this ticket while ticket status is POST.
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/808f5b661a0f60c45ab1ba1d5e212d045eb0695a commit 808f5b661a0f60c45ab1ba1d5e212d045eb0695a Author: Harpreet Kataria <hkataria> AuthorDate: Thu Aug 27 12:05:47 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Aug 27 14:57:59 2015 -0400 Fixed flash message to be more generic. Fixed existing spec test to check for updated flash message. https://bugzilla.redhat.com/show_bug.cgi?id=1221532 https://bugzilla.redhat.com/show_bug.cgi?id=1243872 app/controllers/application_controller.rb | 8 +++++--- spec/controllers/application_controller_spec.rb | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-)
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=c6277a441b89e6dd7321344e9b20c6b3d498d217 commit c6277a441b89e6dd7321344e9b20c6b3d498d217 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Aug 27 17:32:25 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Aug 27 17:32:25 2015 -0400 Fixed flash message to be more generic. Fixed existing spec test to check for updated flash message. https://bugzilla.redhat.com/show_bug.cgi?id=1221532 https://bugzilla.redhat.com/show_bug.cgi?id=1243872 vmdb/app/controllers/application_controller.rb | 8 +++++--- vmdb/spec/controllers/application_controller_spec.rb | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-)
New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=3783724bf2e97bd545537858ab7e8b009202a412 commit 3783724bf2e97bd545537858ab7e8b009202a412 Merge: 1196c64 c6277a4 Author: Dan Clarizio <dclarizi> AuthorDate: Fri Aug 28 11:02:23 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Fri Aug 28 11:02:23 2015 -0400 Merge branch '54z_bz_1243872' into '5.4.z' Fixed flash message to be more generic. Fixed existing spec test to check for updated flash message. https://bugzilla.redhat.com/show_bug.cgi?id=1221532 https://bugzilla.redhat.com/show_bug.cgi?id=1243872 @dclarizio please review, clean path was applied original PR: https://github.com/ManageIQ/manageiq/pull/4079 See merge request !240 vmdb/app/controllers/application_controller.rb | 8 +++++--- vmdb/spec/controllers/application_controller_spec.rb | 2 +- 2 files changed, 6 insertions(+), 4 deletions(-)
Good to go. Verified in 5.5.0.1-alpha1.20150915151429_2230bd4
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2015:2551