Bug 1243915

Summary:	Review Request: perl-Pinto - Curate a repository of Perl modules
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Pinto-0.09999-2.fc24 perl-Pinto-0.09999-2.fc23	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-07-29 08:29:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1131085

Description Jitka Plesnikova 2015-07-16 14:59:46 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto-0.09999-1.fc24.src.rpm
Description:
Pinto is an application for creating and managing a custom CPAN-like
repository of Perl modules. The purpose of such a repository is to provide
a stable, curated stack of dependencies from which you can reliably build,
test, and deploy your application using the standard Perl tool chain. Pinto
supports various operations for gathering and managing distribution
dependencies within the repository, so that you can control precisely which
dependencies go into your application.

Fedora Account System Username: jplesnik

Comment 1 Petr Šabata 2015-07-21 16:51:25 UTC

* The pinto and pintod apps could be probably subpackaged; would that be feasible?  I'm not sure if there are any other applications using these modules.  Perhaps it doesn't make sense.

* pintod is a service and should install a systemd service unit file.  I see old releases of Pinto used to ship with an initscript (0.83~0.99, at least).  You could probably use that for inspiration.

* File::Path is only used by the unused bundled cpanm.  Drop it from your buildtime dep list.

* I can't see Test::Warn mentioned anywhere in the tarball.  Unless you have some specific reasons for it, drop it from your dep list too.

* Encode and Starman don't appear to be required at buildtime.  You may drop them from your buildtime dep list.

Comment 2 Jitka Plesnikova 2015-07-27 13:21:30 UTC

Updated BRs and added systemd service file.
I don't subpackage the apps for now. I'll do it later if I find some reason for it. 

Spec URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto-0.09999-2.fc24.src.rpm

Comment 3 Petr Šabata 2015-07-28 11:16:08 UTC

BRs are fine now.

Regarding the service... It looks rather obscure to me.
I suggest you put the configuration file in %{_sysconfdir}/sysconfig/pintod and then use EnvironmentFiles in the unit file.  See https://fedoraproject.org/wiki/Packaging:Systemd#EnvironmentFiles_and_support_for_.2Fetc.2Fsysconfig_files

Comment 4 Jitka Plesnikova 2015-07-28 11:54:25 UTC

Updated files are on the same link.

Comment 5 Petr Šabata 2015-07-28 13:54:57 UTC

That looks better.  Approving.

Comment 6 Jitka Plesnikova 2015-07-28 14:12:41 UTC

New Package SCM Request
=======================
Package Name: perl-Pinto
Short Description: Curate a repository of Perl modules
Upstream URL: http://search.cpan.org/dist/Pinto/
Owners: jplesnik ppisar psabata
Branches: f23
InitialCC: perl-sig

Comment 7 Gwyn Ciesla 2015-07-28 17:03:36 UTC

Git done (by process-git-requests).

Comment 8 Jitka Plesnikova 2015-07-29 08:29:43 UTC

Thank you for the review and the repository.