Spec URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto-0.09999-1.fc24.src.rpm Description: Pinto is an application for creating and managing a custom CPAN-like repository of Perl modules. The purpose of such a repository is to provide a stable, curated stack of dependencies from which you can reliably build, test, and deploy your application using the standard Perl tool chain. Pinto supports various operations for gathering and managing distribution dependencies within the repository, so that you can control precisely which dependencies go into your application. Fedora Account System Username: jplesnik
* The pinto and pintod apps could be probably subpackaged; would that be feasible? I'm not sure if there are any other applications using these modules. Perhaps it doesn't make sense. * pintod is a service and should install a systemd service unit file. I see old releases of Pinto used to ship with an initscript (0.83~0.99, at least). You could probably use that for inspiration. * File::Path is only used by the unused bundled cpanm. Drop it from your buildtime dep list. * I can't see Test::Warn mentioned anywhere in the tarball. Unless you have some specific reasons for it, drop it from your dep list too. * Encode and Starman don't appear to be required at buildtime. You may drop them from your buildtime dep list.
Updated BRs and added systemd service file. I don't subpackage the apps for now. I'll do it later if I find some reason for it. Spec URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Pinto/perl-Pinto-0.09999-2.fc24.src.rpm
BRs are fine now. Regarding the service... It looks rather obscure to me. I suggest you put the configuration file in %{_sysconfdir}/sysconfig/pintod and then use EnvironmentFiles in the unit file. See https://fedoraproject.org/wiki/Packaging:Systemd#EnvironmentFiles_and_support_for_.2Fetc.2Fsysconfig_files
Updated files are on the same link.
That looks better. Approving.
New Package SCM Request ======================= Package Name: perl-Pinto Short Description: Curate a repository of Perl modules Upstream URL: http://search.cpan.org/dist/Pinto/ Owners: jplesnik ppisar psabata Branches: f23 InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.