Bug 1244315
| Summary: | Review Request: rpmdistro-gitoverlay - Manage an overlay repository of RPMs from upstream git | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Colin Walters <walters> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dev, dsupriadi, igor.raits, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-08-29 00:45:20 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Colin Walters
2015-07-17 18:36:00 UTC
Hi Colin! The %changelog is missing in the .spec. Cheers, Florian Hi Florian, I usually add the %changelog after it's added to Fedora. It's a source of merge conflicts, so I delay as long as possible. Hi Colin, providing something general like "initial packaging" should be fine for %changelog and doesn't produce that much merge conflicts. The versioning is confusing. In the spec-file it is 2015.1 and in the github repository v2015.2. I see and can reproduce how to get Source0. But if would be great, if you could reference the source to a unique commit - https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services Cheers, Florian Spec URL; https://raw.githubusercontent.com/cgwalters/rpmdistro-gitoverlay/master/rpmdistro-gitoverlay.spec Where is SRPM Url? it's required for review. Any way some notes. -> BuildRequires: git git-core please -> Requires: yum-plugin-priorities why yum? is it really required? -> Source0: %{name}-%{version}.tar.xz why not %{url}/archive/%{shortcommit}.tar.gz#/%{name}-%{shortcommit}.tar.gz? OK, I'll update soon to the new git guidelines. (Ironically rpmdistro-gitoverlay is intended to fix all that...) This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |