Hide Forgot
Spec URL: https://github.com/cgwalters/rpmdistro-gitoverlay SRPM URL: You can generate it with this tool! Description: It's in the spec Fedora Account System Username: walters
Hi Colin! The %changelog is missing in the .spec. Cheers, Florian
Hi Florian, I usually add the %changelog after it's added to Fedora. It's a source of merge conflicts, so I delay as long as possible.
Hi Colin, providing something general like "initial packaging" should be fine for %changelog and doesn't produce that much merge conflicts. The versioning is confusing. In the spec-file it is 2015.1 and in the github repository v2015.2. I see and can reproduce how to get Source0. But if would be great, if you could reference the source to a unique commit - https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services Cheers, Florian
Spec URL; https://raw.githubusercontent.com/cgwalters/rpmdistro-gitoverlay/master/rpmdistro-gitoverlay.spec Where is SRPM Url? it's required for review. Any way some notes. -> BuildRequires: git git-core please -> Requires: yum-plugin-priorities why yum? is it really required? -> Source0: %{name}-%{version}.tar.xz why not %{url}/archive/%{shortcommit}.tar.gz#/%{name}-%{shortcommit}.tar.gz?
OK, I'll update soon to the new git guidelines. (Ironically rpmdistro-gitoverlay is intended to fix all that...)