Bug 1244315 - Review Request: rpmdistro-gitoverlay - Manage an overlay repository of RPMs from upstream git
Summary: Review Request: rpmdistro-gitoverlay - Manage an overlay repository of RPMs f...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Igor Gnatenko
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-17 18:36 UTC by Colin Walters
Modified: 2018-07-31 21:20 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed:
ignatenko: fedora-review?


Attachments (Terms of Use)

Description Colin Walters 2015-07-17 18:36:00 UTC
Spec URL: https://github.com/cgwalters/rpmdistro-gitoverlay 
SRPM URL: You can generate it with this tool!
Description: It's in the spec
Fedora Account System Username: walters

Comment 1 Florian "der-flo" Lehner 2015-07-25 11:50:21 UTC
Hi Colin!

The %changelog is missing in the .spec.


Cheers,
 Florian

Comment 2 Colin Walters 2015-07-26 16:26:47 UTC
Hi Florian,

I usually add the %changelog after it's added to Fedora.  It's a source of merge conflicts, so I delay as long as possible.

Comment 3 Florian "der-flo" Lehner 2015-07-26 18:13:27 UTC
Hi Colin,

providing something general like "initial packaging" should be fine for %changelog and doesn't produce that much merge conflicts.

The versioning is confusing. In the spec-file it is 2015.1 and in the github repository v2015.2.

I see and can reproduce how to get Source0.  But if would be great, if you could reference the source to a unique commit - https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Git_Hosting_Services

Cheers,
 Florian

Comment 4 Igor Gnatenko 2015-08-07 14:00:30 UTC
Spec URL; https://raw.githubusercontent.com/cgwalters/rpmdistro-gitoverlay/master/rpmdistro-gitoverlay.spec

Where is SRPM Url? it's required for review.

Any way some notes.

-> BuildRequires: git
   git-core please

-> Requires: yum-plugin-priorities
   why yum? is it really required?

-> Source0: %{name}-%{version}.tar.xz
   why not %{url}/archive/%{shortcommit}.tar.gz#/%{name}-%{shortcommit}.tar.gz?

Comment 5 Colin Walters 2015-08-08 00:47:55 UTC
OK, I'll update soon to the new git guidelines.

(Ironically rpmdistro-gitoverlay is intended to fix all that...)


Note You need to log in before you can comment on or make changes to this bug.