Bug 1245045
Summary: | Data Loss:Remove brick commit passing when remove-brick process has not even started(due to killing glusterd) | |||
---|---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Atin Mukherjee <amukherj> | |
Component: | glusterd | Assignee: | Atin Mukherjee <amukherj> | |
Status: | CLOSED CURRENTRELEASE | QA Contact: | ||
Severity: | urgent | Docs Contact: | ||
Priority: | unspecified | |||
Version: | mainline | CC: | bugs, gluster-bugs, nbalacha, nchilaka, nsathyan, rhs-bugs, sabansal, storage-qa-internal | |
Target Milestone: | --- | Keywords: | Reopened, Triaged | |
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | glusterfs-3.8rc2 | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | ||
Clone Of: | 1236038 | |||
: | 1256265 (view as bug list) | Environment: | ||
Last Closed: | 2016-06-16 13:25:33 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1236038 | |||
Bug Blocks: | 1256265 |
Comment 1
Anand Avati
2015-07-21 08:43:11 UTC
REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick start if glusterd is down of the host of the brick) posted (#2) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick commit if glusterd is down of the host of the brick) posted (#3) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick commit if glusterd is down of the host of the brick) posted (#4) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick commit if glusterd is down of the host of the brick) posted (#5) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick commit if glusterd is down of the host of the brick) posted (#6) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick commit if glusterd is down of the host of the brick) posted (#7) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick) posted (#8) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick) posted (#9) for review on master by Atin Mukherjee (amukherj) REVIEW: http://review.gluster.org/11726 (glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick) posted (#11) for review on master by Atin Mukherjee (amukherj) COMMIT: http://review.gluster.org/11726 committed in master by Krishnan Parthasarathi (kparthas) ------ commit c9d462dc8c1250c3f3f42ca149bb062fe690335b Author: Atin Mukherjee <amukherj> Date: Tue Jul 21 09:57:43 2015 +0530 glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick remove brick stage blindly starts the remove brick operation even if the glusterd instance of the node hosting the brick is down. Operationally its incorrect and this could result into a inconsistent rebalance status across all the nodes as the originator of this command will always have the rebalance status to 'DEFRAG_NOT_STARTED', however when the glusterd instance on the other nodes comes up, will trigger rebalance and make the status to completed once the rebalance is finished. This patch fixes two things: 1. Add a validation in remove brick to check whether all the peers hosting the bricks to be removed are up. 2. Don't copy volinfo->rebal.dict from stale volinfo during restore as this might end up in a incosistent node_state.info file resulting into volume status command failure. Change-Id: Ia4a76865c05037d49eec5e3bbfaf68c1567f1f81 BUG: 1245045 Signed-off-by: Atin Mukherjee <amukherj> Reviewed-on: http://review.gluster.org/11726 Tested-by: NetBSD Build System <jenkins.org> Reviewed-by: N Balachandran <nbalacha> Reviewed-by: Krishnan Parthasarathi <kparthas> Fix for this BZ is already present in a GlusterFS release. You can find clone of this BZ, fixed in a GlusterFS release and closed. Hence closing this mainline BZ as well. This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report. glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/ [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |