Red Hat Bugzilla – Bug 1256265
Data Loss:Remove brick commit passing when remove-brick process has not even started(due to killing glusterd)
Last modified: 2015-09-09 05:40:22 EDT
REVIEW: http://review.gluster.org/11996 (glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick) posted (#1) for review on release-3.7 by Atin Mukherjee (firstname.lastname@example.org)
COMMIT: http://review.gluster.org/11996 committed in release-3.7 by Kaushal M (email@example.com)
Author: Atin Mukherjee <firstname.lastname@example.org>
Date: Tue Jul 21 09:57:43 2015 +0530
glusterd: Don't allow remove brick start/commit if glusterd is down of the host of the brick
Backport of http://review.gluster.org/#/c/11726/
remove brick stage blindly starts the remove brick operation even if the
glusterd instance of the node hosting the brick is down. Operationally its
incorrect and this could result into a inconsistent rebalance status across all
the nodes as the originator of this command will always have the rebalance
status to 'DEFRAG_NOT_STARTED', however when the glusterd instance on the other
nodes comes up, will trigger rebalance and make the status to completed once the
rebalance is finished.
This patch fixes two things:
1. Add a validation in remove brick to check whether all the peers hosting the
bricks to be removed are up.
2. Don't copy volinfo->rebal.dict from stale volinfo during restore as this
might end up in a incosistent node_state.info file resulting into volume status
Signed-off-by: Atin Mukherjee <email@example.com>
Tested-by: NetBSD Build System <firstname.lastname@example.org>
Reviewed-by: N Balachandran <email@example.com>
Reviewed-by: Krishnan Parthasarathi <firstname.lastname@example.org>
Tested-by: Gluster Build System <email@example.com>
Reviewed-by: Kaushal M <firstname.lastname@example.org>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.4, please open a new bug report.
glusterfs-3.7.4 has been announced on the Gluster mailinglists , packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist  and the update infrastructure for your distribution.