Bug 1245717
| Summary: | Smart state analysis fails on EC2 instances with undefined method ` + 'for nil:NilClass " | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Chris Pelland <cpelland> |
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> |
| Status: | CLOSED ERRATA | QA Contact: | Sean Myers <sean.myers> |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 5.4.0 | CC: | cpelland, dajohnso, hkataria, jhardy, kmorey, ldomb, mfeifer, mpovolny, obarenbo, rananda, roliveri, sean.myers |
| Target Milestone: | GA | Keywords: | ZStream |
| Target Release: | 5.4.2 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 5.4.2.0 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1240337 | Environment: | |
| Last Closed: | 2015-09-09 12:25:59 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1240337 | ||
| Bug Blocks: | |||
|
Comment 1
Oleg Barenboim
2015-07-28 14:28:21 UTC
New commit detected on manageiq/master: https://github.com/ManageIQ/manageiq/commit/981632f8d77a7a0b5319d303db029fae01d5521f commit 981632f8d77a7a0b5319d303db029fae01d5521f Author: Harpreet Kataria <hkataria> AuthorDate: Tue Aug 11 12:28:44 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Aug 11 16:38:20 2015 -0400 Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 app/helpers/application_helper/toolbar_builder.rb | 1 + app/models/manageiq/providers/amazon/cloud_manager/vm.rb | 4 ++++ app/models/manageiq/providers/cloud_manager/vm.rb | 4 ++++ app/models/manageiq/providers/openstack/cloud_manager/vm.rb | 4 ++++ app/models/manageiq/providers/redhat/infra_manager/vm.rb | 4 ++++ app/models/manageiq/providers/vmware/infra_manager/vm.rb | 4 ++++ product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- spec/helpers/application_helper/toolbar_builder_spec.rb | 11 +++++++++++ spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 9 files changed, 46 insertions(+), 2 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2a557dfa43c0fa2a6263c5830a4290b38c24d06d commit 2a557dfa43c0fa2a6263c5830a4290b38c24d06d Author: Harpreet Kataria <hkataria> AuthorDate: Mon Aug 17 11:38:56 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Aug 18 10:49:23 2015 -0400 Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 vmdb/app/helpers/application_helper.rb | 1 + vmdb/app/models/vm.rb | 4 ++++ vmdb/app/models/vm_amazon.rb | 4 ++++ vmdb/app/models/vm_cloud.rb | 4 ++++ vmdb/app/models/vm_openstack.rb | 4 ++++ vmdb/app/models/vm_redhat.rb | 4 ++++ vmdb/app/models/vm_vmware.rb | 4 ++++ vmdb/product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- vmdb/spec/helpers/application_helper_spec.rb | 11 +++++++++++ vmdb/spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 10 files changed, 50 insertions(+), 2 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=598799c30b3ee2a0f63409fcdb36ba7ffccc66f8 commit 598799c30b3ee2a0f63409fcdb36ba7ffccc66f8 Merge: 5ae8c86 2a557df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Aug 18 12:33:59 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Aug 18 12:33:59 2015 -0400 Merge branch '54z_bz_1245717' into '5.4.z' Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 @dclarizio please review, had to make some changes by hand, VM related models & toolbar builder code have been moved/renamed on upstream. original PR: https://github.com/ManageIQ/manageiq/pull/3808 See merge request !225 vmdb/app/helpers/application_helper.rb | 1 + vmdb/app/models/vm.rb | 4 ++++ vmdb/app/models/vm_amazon.rb | 4 ++++ vmdb/app/models/vm_cloud.rb | 4 ++++ vmdb/app/models/vm_openstack.rb | 4 ++++ vmdb/app/models/vm_redhat.rb | 4 ++++ vmdb/app/models/vm_vmware.rb | 4 ++++ vmdb/product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- vmdb/spec/helpers/application_helper_spec.rb | 11 +++++++++++ vmdb/spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 10 files changed, 50 insertions(+), 2 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=598799c30b3ee2a0f63409fcdb36ba7ffccc66f8 commit 598799c30b3ee2a0f63409fcdb36ba7ffccc66f8 Merge: 5ae8c86 2a557df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Aug 18 12:33:59 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Aug 18 12:33:59 2015 -0400 Merge branch '54z_bz_1245717' into '5.4.z' Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 @dclarizio please review, had to make some changes by hand, VM related models & toolbar builder code have been moved/renamed on upstream. original PR: https://github.com/ManageIQ/manageiq/pull/3808 See merge request !225 vmdb/app/helpers/application_helper.rb | 1 + vmdb/app/models/vm.rb | 4 ++++ vmdb/app/models/vm_amazon.rb | 4 ++++ vmdb/app/models/vm_cloud.rb | 4 ++++ vmdb/app/models/vm_openstack.rb | 4 ++++ vmdb/app/models/vm_redhat.rb | 4 ++++ vmdb/app/models/vm_vmware.rb | 4 ++++ vmdb/product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- vmdb/spec/helpers/application_helper_spec.rb | 11 +++++++++++ vmdb/spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 10 files changed, 50 insertions(+), 2 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2a557dfa43c0fa2a6263c5830a4290b38c24d06d commit 2a557dfa43c0fa2a6263c5830a4290b38c24d06d Author: Harpreet Kataria <hkataria> AuthorDate: Mon Aug 17 11:38:56 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Aug 18 10:49:23 2015 -0400 Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 vmdb/app/helpers/application_helper.rb | 1 + vmdb/app/models/vm.rb | 4 ++++ vmdb/app/models/vm_amazon.rb | 4 ++++ vmdb/app/models/vm_cloud.rb | 4 ++++ vmdb/app/models/vm_openstack.rb | 4 ++++ vmdb/app/models/vm_redhat.rb | 4 ++++ vmdb/app/models/vm_vmware.rb | 4 ++++ vmdb/product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- vmdb/spec/helpers/application_helper_spec.rb | 11 +++++++++++ vmdb/spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 10 files changed, 50 insertions(+), 2 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2a557dfa43c0fa2a6263c5830a4290b38c24d06d commit 2a557dfa43c0fa2a6263c5830a4290b38c24d06d Author: Harpreet Kataria <hkataria> AuthorDate: Mon Aug 17 11:38:56 2015 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Aug 18 10:49:23 2015 -0400 Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 vmdb/app/helpers/application_helper.rb | 1 + vmdb/app/models/vm.rb | 4 ++++ vmdb/app/models/vm_amazon.rb | 4 ++++ vmdb/app/models/vm_cloud.rb | 4 ++++ vmdb/app/models/vm_openstack.rb | 4 ++++ vmdb/app/models/vm_redhat.rb | 4 ++++ vmdb/app/models/vm_vmware.rb | 4 ++++ vmdb/product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- vmdb/spec/helpers/application_helper_spec.rb | 11 +++++++++++ vmdb/spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 10 files changed, 50 insertions(+), 2 deletions(-) New commit detected on cfme/5.4.z: https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=598799c30b3ee2a0f63409fcdb36ba7ffccc66f8 commit 598799c30b3ee2a0f63409fcdb36ba7ffccc66f8 Merge: 5ae8c86 2a557df Author: Dan Clarizio <dclarizi> AuthorDate: Tue Aug 18 12:33:59 2015 -0400 Commit: Dan Clarizio <dclarizi> CommitDate: Tue Aug 18 12:33:59 2015 -0400 Merge branch '54z_bz_1245717' into '5.4.z' Added model support to determine if Smartstate Analysis is supported. - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance. - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image" https://bugzilla.redhat.com/show_bug.cgi?id=1240337 https://bugzilla.redhat.com/show_bug.cgi?id=1245717 @dclarizio please review, had to make some changes by hand, VM related models & toolbar builder code have been moved/renamed on upstream. original PR: https://github.com/ManageIQ/manageiq/pull/3808 See merge request !225 vmdb/app/helpers/application_helper.rb | 1 + vmdb/app/models/vm.rb | 4 ++++ vmdb/app/models/vm_amazon.rb | 4 ++++ vmdb/app/models/vm_cloud.rb | 4 ++++ vmdb/app/models/vm_openstack.rb | 4 ++++ vmdb/app/models/vm_redhat.rb | 4 ++++ vmdb/app/models/vm_vmware.rb | 4 ++++ vmdb/product/toolbars/x_vm_cloud_center_tb.yaml | 4 ++-- vmdb/spec/helpers/application_helper_spec.rb | 11 +++++++++++ vmdb/spec/models/vm_or_template_spec.rb | 12 ++++++++++++ 10 files changed, 50 insertions(+), 2 deletions(-) SmartState analysis option is not available on an instance's detail page, but the option is still available when viewing instances as quadicons on the provider page. Check a quad's checkbox for an EC2 instance, and then Configuration > "Perform SmartState Analysis" is still available. Moving to ON_DEV based on jhardy's statement in #4: "the UI should not show operations that are not supported on the provider" Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-1744.html |