Bug 1245717 - Smart state analysis fails on EC2 instances with undefined method ` + 'for nil:NilClass "
Summary: Smart state analysis fails on EC2 instances with undefined method ` + 'for ni...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.4.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.4.2
Assignee: Harpreet Kataria
QA Contact: Sean Myers
URL:
Whiteboard:
Depends On: 1240337
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-22 14:56 UTC by Chris Pelland
Modified: 2015-09-09 13:10 UTC (History)
12 users (show)

Fixed In Version: 5.4.2.0
Doc Type: Bug Fix
Doc Text:
Clone Of: 1240337
Environment:
Last Closed: 2015-09-09 12:25:59 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:1744 0 normal SHIPPED_LIVE CFME 5.4.2 bug fixes, and enhancement update 2015-09-09 16:25:05 UTC

Comment 1 Oleg Barenboim 2015-07-28 14:28:21 UTC
Chris - reading this, it looks like there are 2 issues here.

1. [RFE] SmartState Analysis for Amazon EC2
2. [BUG] UI should inform user that SmartState Analysis is not supported for Amazon EC2 until above is implemented.

So, #1 will not happen for cfme-5.4.z

If we want to pursue #2 for cfme-5.4.z, then this bug needs to be reclassified as a UI bug and re-assigned to DanC.

Comment 8 CFME Bot 2015-08-18 02:26:40 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/981632f8d77a7a0b5319d303db029fae01d5521f

commit 981632f8d77a7a0b5319d303db029fae01d5521f
Author:     Harpreet Kataria <hkataria>
AuthorDate: Tue Aug 11 12:28:44 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Aug 11 16:38:20 2015 -0400

    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717

 app/helpers/application_helper/toolbar_builder.rb           |  1 +
 app/models/manageiq/providers/amazon/cloud_manager/vm.rb    |  4 ++++
 app/models/manageiq/providers/cloud_manager/vm.rb           |  4 ++++
 app/models/manageiq/providers/openstack/cloud_manager/vm.rb |  4 ++++
 app/models/manageiq/providers/redhat/infra_manager/vm.rb    |  4 ++++
 app/models/manageiq/providers/vmware/infra_manager/vm.rb    |  4 ++++
 product/toolbars/x_vm_cloud_center_tb.yaml                  |  4 ++--
 spec/helpers/application_helper/toolbar_builder_spec.rb     | 11 +++++++++++
 spec/models/vm_or_template_spec.rb                          | 12 ++++++++++++
 9 files changed, 46 insertions(+), 2 deletions(-)

Comment 9 CFME Bot 2015-08-18 22:07:22 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2a557dfa43c0fa2a6263c5830a4290b38c24d06d

commit 2a557dfa43c0fa2a6263c5830a4290b38c24d06d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Aug 17 11:38:56 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Aug 18 10:49:23 2015 -0400

    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717

 vmdb/app/helpers/application_helper.rb          |  1 +
 vmdb/app/models/vm.rb                           |  4 ++++
 vmdb/app/models/vm_amazon.rb                    |  4 ++++
 vmdb/app/models/vm_cloud.rb                     |  4 ++++
 vmdb/app/models/vm_openstack.rb                 |  4 ++++
 vmdb/app/models/vm_redhat.rb                    |  4 ++++
 vmdb/app/models/vm_vmware.rb                    |  4 ++++
 vmdb/product/toolbars/x_vm_cloud_center_tb.yaml |  4 ++--
 vmdb/spec/helpers/application_helper_spec.rb    | 11 +++++++++++
 vmdb/spec/models/vm_or_template_spec.rb         | 12 ++++++++++++
 10 files changed, 50 insertions(+), 2 deletions(-)

Comment 10 CFME Bot 2015-08-18 22:08:14 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=598799c30b3ee2a0f63409fcdb36ba7ffccc66f8

commit 598799c30b3ee2a0f63409fcdb36ba7ffccc66f8
Merge: 5ae8c86 2a557df
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Aug 18 12:33:59 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Aug 18 12:33:59 2015 -0400

    Merge branch '54z_bz_1245717' into '5.4.z'
    
    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717
    
    @dclarizio please review, had to make some changes by hand, VM related models & toolbar builder code have been moved/renamed on upstream.
    original PR: https://github.com/ManageIQ/manageiq/pull/3808
    
    See merge request !225

 vmdb/app/helpers/application_helper.rb          |  1 +
 vmdb/app/models/vm.rb                           |  4 ++++
 vmdb/app/models/vm_amazon.rb                    |  4 ++++
 vmdb/app/models/vm_cloud.rb                     |  4 ++++
 vmdb/app/models/vm_openstack.rb                 |  4 ++++
 vmdb/app/models/vm_redhat.rb                    |  4 ++++
 vmdb/app/models/vm_vmware.rb                    |  4 ++++
 vmdb/product/toolbars/x_vm_cloud_center_tb.yaml |  4 ++--
 vmdb/spec/helpers/application_helper_spec.rb    | 11 +++++++++++
 vmdb/spec/models/vm_or_template_spec.rb         | 12 ++++++++++++
 10 files changed, 50 insertions(+), 2 deletions(-)

Comment 11 CFME Bot 2015-08-18 22:08:56 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=598799c30b3ee2a0f63409fcdb36ba7ffccc66f8

commit 598799c30b3ee2a0f63409fcdb36ba7ffccc66f8
Merge: 5ae8c86 2a557df
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Aug 18 12:33:59 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Aug 18 12:33:59 2015 -0400

    Merge branch '54z_bz_1245717' into '5.4.z'
    
    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717
    
    @dclarizio please review, had to make some changes by hand, VM related models & toolbar builder code have been moved/renamed on upstream.
    original PR: https://github.com/ManageIQ/manageiq/pull/3808
    
    See merge request !225

 vmdb/app/helpers/application_helper.rb          |  1 +
 vmdb/app/models/vm.rb                           |  4 ++++
 vmdb/app/models/vm_amazon.rb                    |  4 ++++
 vmdb/app/models/vm_cloud.rb                     |  4 ++++
 vmdb/app/models/vm_openstack.rb                 |  4 ++++
 vmdb/app/models/vm_redhat.rb                    |  4 ++++
 vmdb/app/models/vm_vmware.rb                    |  4 ++++
 vmdb/product/toolbars/x_vm_cloud_center_tb.yaml |  4 ++--
 vmdb/spec/helpers/application_helper_spec.rb    | 11 +++++++++++
 vmdb/spec/models/vm_or_template_spec.rb         | 12 ++++++++++++
 10 files changed, 50 insertions(+), 2 deletions(-)

Comment 12 CFME Bot 2015-08-18 22:09:32 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2a557dfa43c0fa2a6263c5830a4290b38c24d06d

commit 2a557dfa43c0fa2a6263c5830a4290b38c24d06d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Aug 17 11:38:56 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Aug 18 10:49:23 2015 -0400

    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717

 vmdb/app/helpers/application_helper.rb          |  1 +
 vmdb/app/models/vm.rb                           |  4 ++++
 vmdb/app/models/vm_amazon.rb                    |  4 ++++
 vmdb/app/models/vm_cloud.rb                     |  4 ++++
 vmdb/app/models/vm_openstack.rb                 |  4 ++++
 vmdb/app/models/vm_redhat.rb                    |  4 ++++
 vmdb/app/models/vm_vmware.rb                    |  4 ++++
 vmdb/product/toolbars/x_vm_cloud_center_tb.yaml |  4 ++--
 vmdb/spec/helpers/application_helper_spec.rb    | 11 +++++++++++
 vmdb/spec/models/vm_or_template_spec.rb         | 12 ++++++++++++
 10 files changed, 50 insertions(+), 2 deletions(-)

Comment 13 CFME Bot 2015-08-18 22:10:10 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=2a557dfa43c0fa2a6263c5830a4290b38c24d06d

commit 2a557dfa43c0fa2a6263c5830a4290b38c24d06d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Aug 17 11:38:56 2015 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Tue Aug 18 10:49:23 2015 -0400

    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717

 vmdb/app/helpers/application_helper.rb          |  1 +
 vmdb/app/models/vm.rb                           |  4 ++++
 vmdb/app/models/vm_amazon.rb                    |  4 ++++
 vmdb/app/models/vm_cloud.rb                     |  4 ++++
 vmdb/app/models/vm_openstack.rb                 |  4 ++++
 vmdb/app/models/vm_redhat.rb                    |  4 ++++
 vmdb/app/models/vm_vmware.rb                    |  4 ++++
 vmdb/product/toolbars/x_vm_cloud_center_tb.yaml |  4 ++--
 vmdb/spec/helpers/application_helper_spec.rb    | 11 +++++++++++
 vmdb/spec/models/vm_or_template_spec.rb         | 12 ++++++++++++
 10 files changed, 50 insertions(+), 2 deletions(-)

Comment 14 CFME Bot 2015-08-18 22:11:31 UTC
New commit detected on cfme/5.4.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=598799c30b3ee2a0f63409fcdb36ba7ffccc66f8

commit 598799c30b3ee2a0f63409fcdb36ba7ffccc66f8
Merge: 5ae8c86 2a557df
Author:     Dan Clarizio <dclarizi>
AuthorDate: Tue Aug 18 12:33:59 2015 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Tue Aug 18 12:33:59 2015 -0400

    Merge branch '54z_bz_1245717' into '5.4.z'
    
    Added model support to determine if Smartstate Analysis is supported.
    
    - Added model support to determine if Smartstate Analysis button is supported for VM/Instances, added a check in toolbar code to display a hover message when button is disabled and not supported for certain types of VM/Instance.
    - Fixed hover text on the toolbar button, title should say "Perform SmartState Analysis on this Instance" instead of "Perform SmartState Analysis on this Image"
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1240337
    https://bugzilla.redhat.com/show_bug.cgi?id=1245717
    
    @dclarizio please review, had to make some changes by hand, VM related models & toolbar builder code have been moved/renamed on upstream.
    original PR: https://github.com/ManageIQ/manageiq/pull/3808
    
    See merge request !225

 vmdb/app/helpers/application_helper.rb          |  1 +
 vmdb/app/models/vm.rb                           |  4 ++++
 vmdb/app/models/vm_amazon.rb                    |  4 ++++
 vmdb/app/models/vm_cloud.rb                     |  4 ++++
 vmdb/app/models/vm_openstack.rb                 |  4 ++++
 vmdb/app/models/vm_redhat.rb                    |  4 ++++
 vmdb/app/models/vm_vmware.rb                    |  4 ++++
 vmdb/product/toolbars/x_vm_cloud_center_tb.yaml |  4 ++--
 vmdb/spec/helpers/application_helper_spec.rb    | 11 +++++++++++
 vmdb/spec/models/vm_or_template_spec.rb         | 12 ++++++++++++
 10 files changed, 50 insertions(+), 2 deletions(-)

Comment 16 Sean Myers 2015-08-24 16:16:45 UTC
SmartState analysis option is not available on an instance's detail page, but the option is still available when viewing instances as quadicons on the provider page. Check a quad's checkbox for an EC2 instance, and then Configuration > "Perform SmartState Analysis" is still available.

Moving to ON_DEV based on jhardy's statement in #4: "the UI should not show operations that are not supported on the provider"

Comment 20 errata-xmlrpc 2015-09-09 12:25:59 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1744.html


Note You need to log in before you can comment on or make changes to this bug.