Bug 1245919

Summary:	USS: Take ref on root inode
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Avra Sengupta <asengupt>
Component:	snapshot	Assignee:	Mohammed Rafi KC <rkavunga>
Status:	CLOSED ERRATA	QA Contact:	Shashank Raj <sraj>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.1	CC:	amainkar, annair, asrivast, byarlaga, rhs-bugs, rjoseph, rkavunga, sashinde, storage-qa-internal
Target Milestone:	---	Keywords:	Triaged, ZStream
Target Release:	RHGS 3.1.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	SNAPSHOT
Fixed In Version:	glusterfs-3.7.1-12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1228520	Environment:
Last Closed:	2015-10-05 07:13:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1228520
Bug Blocks:	1228521, 1251815

Description Avra Sengupta 2015-07-23 06:14:32 UTC

+++ This bug was initially created as a clone of Bug #1228520 +++

Description of problem:

<snip from xlators/features/snapview-client/src/snapview-client.c>


       root_loc.gfid[15] = 1;
       root_loc.inode = loc->inode->table->root;
       root_loc.inode->ia_type = IA_IFDIR;
       temp_loc = &root_loc;

</snip>
It is better to take a ref on root inode in above case.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Mohammed Rafi KC on 2015-06-05 02:28:29 EDT ---

upstream patch : http://review.gluster.org/10750

Comment 2 Mohammed Rafi KC 2015-07-23 08:35:07 UTC

upstream patch : http://review.gluster.org/#/c/11094/

Comment 3 Avra Sengupta 2015-08-05 08:35:18 UTC

Patch merged upstream (http://review.gluster.org/10750)
Awaiting release 3.7 merge (http://review.gluster.org/#/c/11094/)

Comment 6 Avra Sengupta 2015-08-14 07:00:13 UTC

Master URL: http://review.gluster.org/#/c/10750/
Release 3.7 URL: http://review.gluster.org/#/c/11094/
RHGS 3.1.1 URL: https://code.engineering.redhat.com/gerrit/#/c/55133/

Comment 8 Shashank Raj 2015-09-03 06:26:42 UTC

This bug depends on the regression run for uss. So once the regression is complete without any issues, we will mark it as verified.

Comment 9 Shashank Raj 2015-09-10 13:59:54 UTC

Since USS regression is passed successfully and no major issues are seen. Hence marking this bug as Verified.

Comment 11 errata-xmlrpc 2015-10-05 07:13:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-1845.html