Bug 1246060

Summary:	[New HostSetupNetworks] Remove custom_properties from vds_interface table and VdsNetworkInterface entity
Product:	[oVirt] ovirt-engine	Reporter:	Alona Kaplan <alkaplan>
Component:	General	Assignee:	Martin Mucha <mmucha>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Stehlik <pstehlik>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	---	CC:	bazulay, bugs, danken, ecohen, gklein, lsurette, mmucha, myakove, rbalakri, yeylon, ylavi
Target Milestone:	ovirt-3.6.0-rc	Keywords:	CodeChange
Target Release:	3.6.0	Flags:	rule-engine: ovirt-3.6.0+ rule-engine: blocker+ ylavi: Triaged+ ylavi: planning_ack+ danken: devel_ack+ rule-engine: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	network
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-04 11:30:35 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1178507

Description Alona Kaplan 2015-07-23 12:05:02 UTC

Description of problem:
Those fields should be part of the network_attachment.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Martin Mucha 2015-08-25 11:52:36 UTC

question: there's HostNetworkAttachmentsPersister which creates new NetworkAttachmetns for existing attached networks and it fills it with custom properties obtained from nic. To preserve this, we need to gather this information from elsewhere. (note: called from: ChangeVDSClusterCommand, AttachNetworkToClusterInternalCommand and HostNetworkTopologyPersisterImpl).

also there has to be some not small rework on ui side, which still works with VdsNetworkInterface and passing custom properties around differently could be problematic.

Comment 2 Martin Mucha 2015-08-25 12:18:31 UTC

... also this leads to rest modification, which, due to backward compatibility, won't be allowed sooner than 4.0. So should we alter target version or just ignore data sent in relevant element?

Comment 3 Alona Kaplan 2015-08-26 10:14:47 UTC

(In reply to Martin Mucha from comment #2)
> ... also this leads to rest modification, which, due to backward
> compatibility, won't be allowed sooner than 4.0. So should we alter target
> version or just ignore data sent in relevant element?

The rest api of the old SetupNetwork command will remain untouched-
The 'customProperties' will still be sent on top of the host nic. So it shouldn't be postponed to 4.0.
The changes should be internal- the parameters of the SetupNetworkCommand and internal engine changes.

Comment 4 Alona Kaplan 2015-08-26 10:18:01 UTC

(In reply to Martin Mucha from comment #1)
> question: there's HostNetworkAttachmentsPersister which creates new
> NetworkAttachmetns for existing attached networks and it fills it with
> custom properties obtained from nic. To preserve this, we need to gather
> this information from elsewhere. (note: called from:
> ChangeVDSClusterCommand, AttachNetworkToClusterInternalCommand and
> HostNetworkTopologyPersisterImpl).
> 

The behavior shouldn't be preserved. The vdsm doesn't report the custom properties. So there is no reason to copy the custom properties of the nic to the attachment.

> also there has to be some not small rework on ui side, which still works
> with VdsNetworkInterface and passing custom properties around differently
> could be problematic.

Comment 5 Sandro Bonazzola 2015-11-04 11:30:35 UTC

oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.