Description of problem: Those fields should be part of the network_attachment. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
question: there's HostNetworkAttachmentsPersister which creates new NetworkAttachmetns for existing attached networks and it fills it with custom properties obtained from nic. To preserve this, we need to gather this information from elsewhere. (note: called from: ChangeVDSClusterCommand, AttachNetworkToClusterInternalCommand and HostNetworkTopologyPersisterImpl). also there has to be some not small rework on ui side, which still works with VdsNetworkInterface and passing custom properties around differently could be problematic.
... also this leads to rest modification, which, due to backward compatibility, won't be allowed sooner than 4.0. So should we alter target version or just ignore data sent in relevant element?
(In reply to Martin Mucha from comment #2) > ... also this leads to rest modification, which, due to backward > compatibility, won't be allowed sooner than 4.0. So should we alter target > version or just ignore data sent in relevant element? The rest api of the old SetupNetwork command will remain untouched- The 'customProperties' will still be sent on top of the host nic. So it shouldn't be postponed to 4.0. The changes should be internal- the parameters of the SetupNetworkCommand and internal engine changes.
(In reply to Martin Mucha from comment #1) > question: there's HostNetworkAttachmentsPersister which creates new > NetworkAttachmetns for existing attached networks and it fills it with > custom properties obtained from nic. To preserve this, we need to gather > this information from elsewhere. (note: called from: > ChangeVDSClusterCommand, AttachNetworkToClusterInternalCommand and > HostNetworkTopologyPersisterImpl). > The behavior shouldn't be preserved. The vdsm doesn't report the custom properties. So there is no reason to copy the custom properties of the nic to the attachment. > also there has to be some not small rework on ui side, which still works > with VdsNetworkInterface and passing custom properties around differently > could be problematic.
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue. If problems still persist, please open a new BZ and reference this one.