Bug 1246121
| Summary: | Disperse volume : client glusterfs crashed while running IO | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Xavi Hernandez <jahernan> |
| Component: | disperse | Assignee: | Xavi Hernandez <jahernan> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 3.7.2 | CC: | annair, asrivast, bugs, byarlaga, gluster-bugs, nsathyan, pkarampu, rhs-bugs |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.7.9 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1243187 | Environment: | |
| Last Closed: | 2015-07-30 09:47:42 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1243187 | ||
| Bug Blocks: | 1233025 | ||
|
Description
Xavi Hernandez
2015-07-23 13:32:51 UTC
REVIEW: http://review.gluster.org/11752 (cluster/ec: Handle race between unlock-timer, new lock) posted (#1) for review on release-3.7 by Xavier Hernandez (xhernandez) COMMIT: http://review.gluster.org/11752 committed in release-3.7 by Xavier Hernandez (xhernandez) ------ commit 75d50eaba3fd7d24874ba8acc9a776c863a932e2 Author: Pranith Kumar K <pkarampu> Date: Wed Jul 15 06:16:54 2015 +0530 cluster/ec: Handle race between unlock-timer, new lock Problem: New lock could come at the time timer is on the way to unlock. This was leading to crash in timer thread because thread executing new lock can free up the timer_link->fop and then timer thread will try to access structures already freed. Fix: If the timer event is fired, set lock->release to true and wait for unlock to complete. Thanks to Xavi and Bhaskar for helping in confirming that this race is the RC. Thanks to Kritika for pointing out and explaining how Avati's patch can be used to fix this bug. > Change-Id: I45fa5470bbc1f03b5f3d133e26d1e0ab24303378 > BUG: 1243187 > Signed-off-by: Pranith Kumar K <pkarampu> > Reviewed-on: http://review.gluster.org/11670 > Tested-by: Gluster Build System <jenkins.com> > Reviewed-by: Xavier Hernandez <xhernandez> > Tested-by: NetBSD Build System <jenkins.org> Change-Id: I9af012e717493684b7cd7d1c63baf2fa401fb542 BUG: 1246121 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/11752 Tested-by: NetBSD Build System <jenkins.org> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Xavier Hernandez <xhernandez> REVIEW: http://review.gluster.org/11796 (timer: fix race between gf_timer_call_cancel() and gf_timer_proc()) posted (#1) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.3, please open a new bug report. glusterfs-3.7.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/12078 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user REVIEW: http://review.gluster.org/11796 (timer: fix race between gf_timer_call_cancel() and gf_timer_proc()) posted (#2) for review on release-3.7 by Pranith Kumar Karampuri (pkarampu) COMMIT: http://review.gluster.org/11796 committed in release-3.7 by Pranith Kumar Karampuri (pkarampu) ------ commit dcd1db157479bf9f9ac3c39fd3fd8cb0359c0779 Author: Anand Avati <avati> Date: Fri Dec 6 17:31:57 2013 -0800 timer: fix race between gf_timer_call_cancel() and gf_timer_proc() >Change-Id: Ie264d3d591352e4a8ddaa90ae2174d9c552396f1 >BUG: 1243187 >Signed-off-by: Anand Avati <avati> >Reviewed-on: http://review.gluster.org/6459 >Reviewed-by: Krutika Dhananjay <kdhananj> >Reviewed-by: Poornima G <pgurusid> >Tested-by: Gluster Build System <jenkins.com> >Reviewed-by: Niels de Vos <ndevos> >(cherry picked from commit ea90c92820ee0ca500345863cdfb5009d08b6ca7) Change-Id: I2bc136e7d676826428afbf57f5afe50e2238fd33 BUG: 1246121 Signed-off-by: Anand Avati <avati> Reviewed-on: http://review.gluster.org/11796 Reviewed-by: Pranith Kumar Karampuri <pkarampu> Tested-by: Pranith Kumar Karampuri <pkarampu> Smoke: Gluster Build System <jenkins.com> CentOS-regression: Gluster Build System <jenkins.com> Reviewed-by: Niels de Vos <ndevos> NetBSD-regression: NetBSD Build System <jenkins.org> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.9, please open a new bug report. glusterfs-3.7.9 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] https://www.gluster.org/pipermail/gluster-users/2016-March/025922.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |