Bug 1246762

Summary: Review Request: telegramqml - Qt Qml qtelegram wrapper library
Product: [Fedora] Fedora Reporter: Helio Chissini de Castro <helio>
Component: Package ReviewAssignee: Daniel Vrátil <me>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: ignatenko, jgrulich, package-review, rdieter, williamjmorenor
Target Milestone: ---Flags: jgrulich: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-23 18:28:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Helio Chissini de Castro 2015-07-25 13:12:39 UTC
Spec URL: https://heliocastro.fedorapeople.org/cutegram/telegramqml.spec
SRPM URL: https://heliocastro.fedorapeople.org/cutegram/telegramqml-0.8.0-2.fc22.src.rpm
Description: Qt Qml qtelegram wrapper library
Fedora Account System Username: heliocastro

Comment 1 Jan Grulich 2015-08-06 09:06:15 UTC
1) ldconfig should be called in %post and %postun
2) The spec file from the URL above is not the same as the one in SRPM
3) Group tag is optional and used only for compatibility with EPEL
4) You are mixing tabs and spaces according to rpmlint

Comment 2 Helio Chissini de Castro 2015-08-06 09:59:06 UTC
Hi

1, 2 and 4 fixed in

https://heliocastro.fedorapeople.org/cutegram/telegramqml-0.8.0-5.fc22.src.rpm
https://heliocastro.fedorapeople.org/cutegram/telegramqml.spec

As group tag is optional, so i kept there

Comment 3 Jan Grulich 2015-08-06 12:05:29 UTC
Ok, looks good now.

Comment 4 Igor Gnatenko 2016-07-23 18:28:21 UTC

*** This bug has been marked as a duplicate of bug 1359400 ***