Bug 1246762 - Review Request: telegramqml - Qt Qml qtelegram wrapper library
Summary: Review Request: telegramqml - Qt Qml qtelegram wrapper library
Keywords:
Status: CLOSED DUPLICATE of bug 1359400
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daniel Vrátil
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2015-07-25 13:12 UTC by Helio Chissini de Castro
Modified: 2016-07-23 18:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-07-23 18:28:21 UTC
Type: ---
Embargoed:
jgrulich: fedora-review+


Attachments (Terms of Use)

Description Helio Chissini de Castro 2015-07-25 13:12:39 UTC
Spec URL: https://heliocastro.fedorapeople.org/cutegram/telegramqml.spec
SRPM URL: https://heliocastro.fedorapeople.org/cutegram/telegramqml-0.8.0-2.fc22.src.rpm
Description: Qt Qml qtelegram wrapper library
Fedora Account System Username: heliocastro

Comment 1 Jan Grulich 2015-08-06 09:06:15 UTC
1) ldconfig should be called in %post and %postun
2) The spec file from the URL above is not the same as the one in SRPM
3) Group tag is optional and used only for compatibility with EPEL
4) You are mixing tabs and spaces according to rpmlint

Comment 2 Helio Chissini de Castro 2015-08-06 09:59:06 UTC
Hi

1, 2 and 4 fixed in

https://heliocastro.fedorapeople.org/cutegram/telegramqml-0.8.0-5.fc22.src.rpm
https://heliocastro.fedorapeople.org/cutegram/telegramqml.spec

As group tag is optional, so i kept there

Comment 3 Jan Grulich 2015-08-06 12:05:29 UTC
Ok, looks good now.

Comment 4 Igor Gnatenko 2016-07-23 18:28:21 UTC

*** This bug has been marked as a duplicate of bug 1359400 ***


Note You need to log in before you can comment on or make changes to this bug.